fix: prevent navigation flash and align Data Slot integrations - #184
Merged
Merged
Conversation
✅ Deploy Preview for fulldev-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed navigation panels briefly appeared before JavaScript initialized. Render closed panels hidden and correct the concrete Data Slot contract mismatches found during the integration audit.
The release contains 36 changed files, including generated registry output. The only added release file is the patch changeset. The general Astro lifecycle helper, audit report, temporary fixtures and debug artifacts have been removed. Existing component initialization is retained.
Retained fixes and documentation
lockScroll; modal styles consume the documented stack-index variables. The CSS scale/base values are our visual styling, not a separate runtime manager.dialog:change,tooltip:changeandtooltip:setevents. Conditional sidebar tooltips are necessary component-specific glue, not a copied Data Slot feature.openprop is passed to the documentedcreateHoverCard(..., { open })controlled option. The data attribute is only the small server-to-browser bridge; the runtime owns behavior.All 18 package READMEs used in the audit were rechecked against this pinned official source and installed 0.2.166 runtime. These are documented API integrations with necessary Astro rendering/styling, not a claim that every line is copied verbatim from Data Slot.
Validation
pnpm build: passed, 80 pages.pnpm check: passed, 0 errors/warnings and 3 existing unused-type/import hints.npm pack --dry-run: passed; audit, helper and unrelated share files are excluded.Preview: https://deploy-preview-184--fulldev-ui.netlify.app/components/navigation-menu/
Release
Patch changeset for fulldev-ui 0.10.0 → 0.10.1. After merge, the existing Changesets workflow creates the version/changelog release PR; merging that PR runs publication. No release or production merge has been performed here.
Floating content inside modals remains a separate known layering issue. General ClientRouter lifecycle/state preservation is not added by this release.