Skip to content

Fix dependency installation and enable Argos visual checks - #3

Merged
silveltman merged 3 commits into
mainfrom
chore/visual-review-trial
Sep 24, 2026
Merged

silveltman merged 3 commits into
mainfrom
chore/visual-review-trial

Conversation

@silveltman

@silveltman silveltman commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Dependency installation stopped because Astro's checking tool pulled a GitHub tarball that pnpm blocks. Update @astrojs/check to 0.9.10 and refresh its dependencies, keeping pnpm's security protection enabled.

Complete the approved Argos trial setup: capture the home and contact pages at mobile and desktop sizes on ready PRs, and upload through GitHub OIDC. Drafts are skipped. No site content or styling changes.

Frozen install, the three-page build, Astro checks, and all four local screenshot checks pass. CodeRabbit CLI ran once with no findings. All four captures were visually inspected. The Netlify deploy preview also passed: preview. Argos baseline and screenshots were visually reviewed and approved. The GitHub screenshot job passed with OIDC upload. The GitHub CodeRabbit review completed on the final head with no actionable findings after one follow-up request. CI actions are pinned to exact release commits, with checkout credential persistence disabled.

Merged to main under the approved workflow rollout. Netlify published merge commit f515b28 successfully. Post-merge Argos checks passed.

@netlify

netlify Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for silveltman ready!

Name Link
🔨 Latest commit 9a77cdf
🔍 Latest deploy log https://app.netlify.com/projects/silveltman/deploys/6ab4d055c7f89f00082976da
😎 Deploy Preview https://deploy-preview-3--silveltman.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@silveltman
silveltman marked this pull request as ready for review September 24, 2026 07:18
@argos-ci

argos-ci Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🔵 Orphan build 4 added Sep 24, 2026, 7:26 AM

@silveltman

Copy link
Copy Markdown
Contributor Author

The CLI review completed with no findings. Local frozen install, Astro checks, build and all four screenshot tests passed. The Netlify preview passed too.

All four CI actions now use immutable release commits, and checkout does not persist credentials. This includes the applicable feedback from the matching Lavis workflow. Please review the final head; this is the single follow-up request for this PR.

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 8ae67f93-3ff1-4811-a92f-cce77b00fca6

📥 Commits

Reviewing files that changed from the base of the PR and between 9b7786c and 9a77cdf.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • .github/workflows/argos.yml
  • .gitignore
  • package.json
  • playwright.config.ts
  • tests/visual.spec.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Adds Playwright visual tests for the home and contact pages, with desktop and mobile projects and an Astro preview server. Adds an Argos GitHub Actions workflow that builds the site and runs the tests for qualifying pull requests and pushes. The workflow uploads test results on failure. Adds ignore rules for generated test artifacts and updates test tooling dependencies.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 9a77c

The visual checks cover ready pull requests without interrupting an existing check for a description edit. No merge-blocking issue remains from the reviewed changes.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies both primary changes: fixing dependency installation and enabling Argos visual checks.
Description check ✅ Passed The description directly explains the dependency update, Argos workflow, visual test coverage, CI behavior, and validation results.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@silveltman
silveltman merged commit f515b28 into main Sep 24, 2026
9 checks passed
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Pull request is closed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant