Conversation
…ted in HfPath.iterdir Newer huggingface_hub releases raise ValueError instead of NotImplementedError when asked to list a namespace such as a user's repositories, which made test_iterdir_parent_iteration fail. Fixes fsspec#562 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #562.
Recent
huggingface_hubreleases reject a single-segment repository id with aValueError("Repository id must be 'namespace/name'…") where older versions raisedNotImplementedError.HfPath.iterdironly translatedNotImplementedErrorintoUnsupportedOperation, so iterating a namespace such as a user (test_iterdir_parent_iteration) now leaked theValueErrorand the test failed.This catches both, so the behaviour is the same on old and new
huggingface_hub.Tested with
huggingface_hub1.31.0:test_hf.pywent from 1 failed / 96 passed to all passing, andtest_hf.py,test_memory.py,test_local.pytogether pass (478 passed).AI disclosure: made with Claude Code under my supervision; I reviewed the change and ran the tests locally.
🤖 Generated with Claude Code