Skip to content

Test request payloads, real values, the timeout, and the CLI through its entry point - #1501

Merged
frenck merged 1 commit into
mainfrom
frenck/sharper-tests
Oct 10, 2026
Merged

frenck merged 1 commit into
mainfrom
frenck/sharper-tests

Conversation

@frenck

@frenck frenck commented Oct 10, 2026

Copy link
Copy Markdown
Owner

Proposed Changes

(Describe the changes and rationale behind them)

Found in a review: several tests would still pass with the code wrong.

  • Test the exact request of every device and DNS change, including false and empty values; hardcoding authorized=True used to pass.
  • Test real values of every real fixture, instead of only that they parse.
  • Test a request that hangs is stopped by the timeout; the old test passed without one.
  • Count the CLI in the coverage, and test its error handling through the entry point, which no test reached.
  • Type the AsyncTyper decorators for plain functions too, and request_timeout as a float.

Related Issues

(GitHub link to related issues or pull requests)

@frenck frenck added the enhancement Enhancement of the code, not introducing new features. label Oct 10, 2026
@frenck
frenck merged commit 7a76a76 into main Oct 10, 2026
39 checks passed
@frenck
frenck deleted the frenck/sharper-tests branch October 10, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement of the code, not introducing new features.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant