Repository navigation
Render settings: ray tracing, upscaling, camera views and plugin status - #595
Merged
Merged
Conversation
Plain-data DLSS / FSR 2 choice and quality for the pipeline applier, plus hooks for the pipeline to report which upscalers run on this machine and the current render scale.
The orbit camera changes its field of view with Ctrl+scroll and can be put at a pose from outside, orbiting on from there. CameraLens reads and sets the vertical field of view a camera really shows, for physical cameras whose gate fit fits the sensor's width too, on the logical (turned) picture.
IPluginStatusSource lets a running plugin say in a few plain lines what it does in the game, like the colorization or the PUP pack it loaded. PluginHost.DescribeStatus collects them, with the plugins that should run but don't and why; a plugin that throws while describing itself is logged, not faulted.
[Medium impact] The PR appears safe to merge; both previous findings are fixed and no new actionable issues were found. SummaryAdds graphics settings, camera controls, and plugin status reports for the Player's pause menu.
No new actionable issues were found in the changes since the previous review. Reviews (2) · Last reviewed commit: "plugins: Skip disposed plugins in the pa..." · Reviewed by Greptile |
After an emergency stop the plugins are disposed but keep their Running state; DescribeStatus no longer calls them. Also puts IsRunning's documentation back on it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetPose);CameraLensreads and sets the vertical field of view of plain and physical cameras.IPluginStatusSource);PluginHost.DescribeStatuscollects them for the Player's pause menu.Commits
Part of the render settings work across repos (all on
feat/render-settings): VisualPinball.Engine, VisualPinball.Unity.Hdrp, VisualPinball.Engine.Player, VisualPinball.Engine.Player.Hdrp, VisualPinball.Engine.PinUp, VisualPinball.Engine.B2sBackglass, VisualPinball.Engine.PinMAME, VisualPinball.Engine.DMD, VisualPinball.Unity.Project.Hdrp and vpe-terminator2.