Repository navigation
player: Start tables that have no gamelogic engine - #592
Merged
Merged
Conversation
The lamp, coil, switch and wire players only got their Awake when the table had a gamelogic engine, but their OnStart always ran, so Player.Start threw in WirePlayer.OnStart and never finished.
 [Medium impact] The PR appears safe to merge. SummaryFixes startup for tables without a game-logic engine.
No actionable issues found. Review was based on code inspection; no runtime tests were run. Reviews (1) · Last reviewed commit: "player: Start tables that have no gamelo..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A table without a gamelogic engine never finished starting: the lamp, coil, switch and wire players only got their
Awakewhen an engine was present, butOnStartalways ran, soPlayer.Startthrew aNullReferenceExceptioninWirePlayer.OnStart.Now these players always get their
Awake(they handle a null engine already). Only the display player still needs an engine, and itsOnDestroytolerates none.Found while loading T2 in the player with its gamelogic engine removed, for comparing the HDRP and URP renders.