Repository navigation
Gather transform groups without a closure for CUDA Oxide - #32
Merged
Merged
Conversation
The CUDA hardware workflow on 393a941 failed to build the device kernels: CUDA Oxide's pinned compiler panics in its device collector ("item_name: no name for DefPath transform::transform_group::{closure}") on the closure passed to `<[usize; N]>::map` in transform_group, which the kernels reach through inverse_core_transform and the overlap operators. 0.5.1 gathered the four values by index. Gather with an indexed loop, like the write-back that follows it. Behaviour is unchanged: workspace tests, the fuzz harness, and the T.834 CPU and Metal comparisons pass as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CUDA hardware workflow on
393a941, the merge of #31, failed at "Lint all targets and features" while building the CUDA Oxide device kernels. The pinned compiler (nightly-2026-04-03) panics in its device collector:#31 changed
jxr_math::transform::transform_groupto gather its values withindices.map(|index| coefficients[index]). The kernels reach that function throughinverse_core_transformand the overlap operators. 0.5.1 gathered the values by index.Change
Gather with an indexed loop, the same pattern as the write-back loop that follows it, and add a comment explaining why. This is the only closure #31 added to
jxr_math::transformandjxr_math::overlap, the two modules the kernels import. The other closures injxr-matheither existed in 0.5.1, which built on the CUDA runner, or are in encoder-only code.jxr-math0.2.1 is not yet published, so the versions in #31 stand.Checks run (aarch64 macOS, Rust 1.99.0)
cargo clippy --workspace --all-targets --all-features -- -D warnings: cleancargo test --workspace --all-featurespassed 590 with 0 failed and 16 ignored;cargo test -p jxr --no-default-featurespassed 104 with 0 failedencode_roundtripfixed cases: 5 passedNot yet validated
CUDA Oxide is unavailable on macOS, so this machine can't build the kernels. The CUDA hardware workflow only runs on
main, so it has to be re-run after this merges, before anything is published.