Repository navigation
Recurring: clear the stale "no e-mail address" error once the client has one - #53
Merged
Merged
Conversation
…has one The error recorded on a schedule was only reset at its next generation, so it kept showing after an address was added to the client. It is now cleared when the client is saved with an address, when an invoice of the schedule is e-mailed successfully, and by a migration for schedules already affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KYH8S5oYUwFL3iDkVPeLFR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A schedule created for a client without an e-mail address recorded
e-mail: the client has no e-mail address. That error was only reset at the schedule's next generation, so it kept showing ("Dernière erreur : …") after an address was added to the client.Fix
e-mail:error.Tests
TestRecurringNoRecipientErrorClearedWhenClientGetsEmail(fails without the fix).go vet ./...andgo test ./...pass.Generated by Claude Code