Repository navigation
PayPal delivered marking: documented request, visible errors, manual retry - #46
Merged
Merged
Conversation
…retry - Send exactly PayPal's documented "without tracking number" tracker (transaction id, DELIVERED, notify_buyer false; no carrier) - No PayPal-Request-Id on the tracking call: PayPal answered every retry with the first (failed) response - PayPal's error is written in the invoice history (once per new error) - On the invoice, a PayPal payment not yet marked delivered shows it, with a button to try again that shows PayPal's answer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016YNKYNHd3eL2ATBFA32LLp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A PayPal payment received on a production instance was not marked delivered on PayPal. Two causes are likely in our code, and the error was only visible in the server logs.
Changes
transaction_id,status: DELIVERED,notify_buyer: false. It no longer sends a carrier or a tracking number.PayPal-Request-Id. With a fixed id, PayPal answered every retry with the cached first (failed) response, so retries could never succeed.Tests
TestPayPalPaymentsnow checks:errors) shown on the invoice;go vet ./...andgo test ./...pass.Generated by Claude Code