fix: return false from fetchField on empty result - #727
Merged
Conversation
SimplePdo::fetchRow() returns null when there are no rows. Guard PdoWrapper::fetchField() so empty queries return false instead of calling getData() on null. Closes #726.
Distinguish empty result sets (false) from SQL NULL columns (null), and keep 0 / '' as assertSame on both PdoWrapper and SimplePdo.
assertEquals for integer-ish fetchField values; keep assertSame for false / empty string and assertNull for SQL NULL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SimplePdo::fetchRow()returnsnullwhen there are no rows;PdoWrapper::fetchField()calledgetData()without a null check and fatals.nullor emptyCollection) and returnfalse. Matching rows still usegetData()+reset().Empty result vs SQL NULL
false(SimplePdo:fetchRowisnull; PdoWrapper: emptyCollection,count === 0).null(reset(['col' => null])isnull; not treated as empty).0or''stays0/''(assertSame).FETCH_ASSOCmaps SQL NULL → PHP null the same on mysql / pgsql / sqlite. Tests use sqlite::memory: as the stand-in; no new live MySQL/Postgres CI in this PR.Test plan
falsenull0and''withassertSameSimplePdoTest49 OK,PdoWrapperTest19 OK