[asafbennatan]

Summary

• Add user-facing titles and translations for the delta generation succeeded, failed, and rejected event reasons.
• Update generated event and delta-generation detail types for the backend OpenAPI change.
• Keep DeltaGenerationProgress as the in-progress event reason.

This UI change depends on the backend OpenAPI change in flightctl/flightctl#3812.

Jira: EDM-6462

Testing

• npm run test:typecheck
• npm run test
• npm run lint

Summary

• Adds translated titles in the shared event UI for delta-generation success, failure, and rejection reasons.
• The objectives also describe generated type updates for the backend OpenAPI change. The available change summary does not identify those files, so their scope is not verified.
• DeltaGenerationProgress remains the in-progress event reason.
• The change affects shared UI components. No changes are reported for platform-specific app code, the Go auth proxy, container builds, E2E tests, or CI configuration.
• The UI change depends on the backend OpenAPI change in flightctl/flightctl#3812.

Checks

The author reports passing npm run test:typecheck, npm run test, and npm run lint. Results were not independently verified.

Risk classification

No applied risk label or labeling criteria were supplied. The classification is unavailable. The available summary identifies a user-facing translation change, but does not establish criteria for risk:ship, risk:show, or risk:ask, or whether the change approaches another classification.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: flightctl/flightctl-ui
• Branch: main
• File: .coderabbit.yaml
• Commit: d69e4cb
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 604625bd-2c16-4ad2-943f-6c781a4dfa84

📥 Commits

Reviewing files that changed from the base of the PR and between d69e4cb and 46daba1.

⛔ Files ignored due to path filters: 3

• libs/i18n/locales/en/translation.json is excluded by !libs/i18n/locales/en/translation.json
• libs/types/models/DeltaGenerationProgressDetails.ts is excluded by !libs/types/models/**
• libs/types/models/Event.ts is excluded by !libs/types/models/**

📒 Files selected for processing: 1

• libs/ui-components/src/components/Events/useEvents.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

getEventReasonTitles now provides translated display titles for succeeded, failed, and rejected delta-generation events.

Changes

Delta-generation event titles

Layer / File(s)	Summary
Add delta-generation reason titles libs/ui-components/src/components/Events/useEvents.ts	Added translated display titles for succeeded, failed, and rejected delta-generation events.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Suggested labels: risk:show, ui-components, api-types, i18n

Suggested reviewers: celdrake

Merge Risk: ⚪ Minimal · up to 46dab

The localized event-title update presents no identified merge-blocking risk.

Pre-merge checks: 14 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Generated-Files-Not-Hand-Edited		The PR changes generated outputs directly. libs/types/models/Event.ts adds three enum values, and libs/types/models/DeltaGenerationProgressDetails.ts changes generated documentation. Both files co…	Do not hand-edit generated files. Apply the API schema change in the OpenAPI source, then run npm run gen-types. Keep the translation keys in useEvents.ts, run npm run i18n, and commit only the generated outputs produced by those comm…

Passed checks: 14 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title accurately identifies the main change: displaying delta generation terminal event reasons. It is specific, concise, and related to the pull request objectives.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets		PASS: The pull request adds event reason enum values, translated UI strings, and a generated-type comment. The changed lines contain no API keys, tokens, passwords, private keys, embedded credentials,…
No-Weak-Crypto		PASS. The pull request adds event enum values, translation strings, and UI mappings for delta-generation outcomes. The changed lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptog…
No-Injection-Vectors		PASS: The pull request adds only static event-reason enum values, static translation strings, and static translated titles. It introduces no eval/exec, dangerouslySetInnerHTML, os.system, exec.Command…
Container-Privileges		PASS: The pull request changes only TypeScript models, event-title logic, and English translations. It adds no container or Kubernetes manifest changes, and the reviewed diff introduces no privileged …
No-Sensitive-Data-In-Logs		PASS: The pull request adds event-reason enum values, translated UI titles, and generated-type documentation only. The reviewed diff introduces no logging calls or log payloads, and no passwords, toke…
Resource-Leaks		PASS: The pull request changes only TypeScript models, the event hook, and English translations. It changes no Go files under proxy/, so it introduces no opened-file, response-body, network-connection…
Unchecked-Errors		PASS: The pull request changes only four TypeScript/JSON files and no files under proxy/. The reviewed diff introduces no Go error handling, blank-identifier assignment, or swallowed error. Existing p…
Ai-Attribution		The contributor-authored PR description and the sole commit do not mention use of an AI tool. The commit has no attribution trailers, including no Co-Authored-By. The check therefore has no AI attri…
I18n-Compliance		PASS: The pull request changes no .tsx files. The three added user-facing strings are in libs/ui-components/src/components/Events/useEvents.ts, and each is passed to t() with a hardcoded string li…

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

Full details: No-Hardcoded-Secrets

Explanation

PASS: The pull request adds event reason enum values, translated UI strings, and a generated-type comment. The changed lines contain no API keys, tokens, passwords, private keys, embedded credentials, credential-like assignments, or long base64 strings.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request adds event enum values, translation strings, and UI mappings for delta-generation outcomes. The changed lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret/token comparison logic. The existing encryption-migration enum entries are unchanged and are labels only.

Full details: No-Injection-Vectors

Explanation

PASS: The pull request adds only static event-reason enum values, static translation strings, and static translated titles. It introduces no eval/exec, dangerouslySetInnerHTML, os.system, exec.Command, or yaml.load usage. Event titles render through ordinary React text interpolation.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only TypeScript models, event-title logic, and English translations. It adds no container or Kubernetes manifest changes, and the reviewed diff introduces no privileged settings such as privileged: true, host PID/network/IPC, SYS_ADMIN, root execution, or allowPrivilegeEscalation: true.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request adds event-reason enum values, translated UI titles, and generated-type documentation only. The reviewed diff introduces no logging calls or log payloads, and no passwords, tokens, API keys, PII, session IDs, hostnames, or customer data.

Full details: Resource-Leaks

Explanation

PASS: The pull request changes only TypeScript models, the event hook, and English translations. It changes no Go files under proxy/, so it introduces no opened-file, response-body, network-connection, or goroutine leak covered by this check.

Full details: Unchecked-Errors

Explanation

PASS: The pull request changes only four TypeScript/JSON files and no files under proxy/. The reviewed diff introduces no Go error handling, blank-identifier assignment, or swallowed error. Existing proxy candidates are outside the pull-request change range.

Full details: Ai-Attribution

Explanation

The contributor-authored PR description and the sole commit do not mention use of an AI tool. The commit has no attribution trailers, including no Co-Authored-By. The check therefore has no AI attribution violation to flag.

Full details: I18n-Compliance

Explanation

PASS: The pull request changes no .tsx files. The three added user-facing strings are in libs/ui-components/src/components/Events/useEvents.ts, and each is passed to t() with a hardcoded string literal. No variable-key t() call was introduced.

Full details: Generated-Files-Not-Hand-Edited

Explanation

The PR changes generated outputs directly. libs/types/models/Event.ts adds three enum values, and libs/types/models/DeltaGenerationProgressDetails.ts changes generated documentation. Both files contain the openapi-typescript-codegen “do not edit” header. The PR contains no OpenAPI specification change; the generator fetches the specification remotely. The PR also edits the generated libs/i18n/locales/en/translation.json.

Resolution

Do not hand-edit generated files. Apply the API schema change in the OpenAPI source, then run npm run gen-types. Keep the translation keys in useEvents.ts, run npm run i18n, and commit only the generated outputs produced by those commands.

✨ Finishing Touches: 💡 1

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

_{Comment @coderabbitai help to get the list of available commands.}