Skip to content

docs: daily doc-review 2026-09-02 — time-zone support, member detail page, RUM remote config - #339

Merged
debidong merged 1 commit into
mainfrom
doc-review/2026-09-02-084531
Sep 2, 2026
Merged

docs: daily doc-review 2026-09-02 — time-zone support, member detail page, RUM remote config#339
debidong merged 1 commit into
mainfrom
doc-review/2026-09-02-084531

Conversation

@flashduty

@flashduty flashduty Bot commented Sep 2, 2026

Copy link
Copy Markdown

Doc Review — 2026-09-02

Mode: diff (since 2026-09-01T08:28:49Z — previous successful run; window to 2026-09-02T08:45Z)
Findings: 10 total — 3 high, 6 medium, 1 low

Changes

Finding Type Module Doc Action
f001 missing_coverage (high) rum zh en/rum/quickstart/app-management.mdx
f002 missing_coverage (high) platform zh en/platform/organization-info.mdx + zh
f003 missing_coverage (high) platform zh en/platform/team-members.mdx
f004 feature_drift (medium) on-call zh en/on-call/incident/search-view-incident.mdx
f005 missing_coverage (medium) on-call zh en/on-call/configuration/schedule.mdx
f006 feature_drift (low) ai-sre zh en/ai-sre/artifacts.mdx
f007–f009 missing_coverage (medium) derivative zh en/changelog/changelog.mdx
f010 missing_coverage (medium) derivative flashduty-website Cross-repo follow-up below (not edited in this PR)

Review checklist

  • Verify remote-config field names/limits against fc-rum types/remote_config.go @ origin/main (rules ≤20, match keys env/app_version/sdk, custom ≤5 keys / 64 chars / 4 KB / 16 KB, history 50 versions, ~4h client switch)
  • RUM remote config is gated on SaaS (rum_remote_config_enabled account setting); doc states rollout availability — confirm the "contact support" wording is what product wants publicly
  • ⚠️ Conflict risk: open PR docs: daily doc-review 2026-09-01 — heartbeat, AI SRE status page drafts, IM feedback + drift fixes #334 edits the same filter table (row 3 default + batch-100 note) and adds a 2026-09-01 changelog entry documenting 告警集成静默检测 — but saas commit 7d8aedd3 (2026-09-02 07:53Z, in this window) commented the silence-detection UI out until backend ships ("静默检测后端上线后恢复"). If both PRs merge as-is, docs will describe a control that is hidden; reviewers should reconcile docs: daily doc-review 2026-09-01 — heartbeat, AI SRE status page drafts, IM feedback + drift fixes #334 with that commit
  • Screenshots for the incident list / schedule pages still show pre-timezone UI (CDN images not regenerated)
  • mint broken-links unavailable in sandbox (no node); ran a scripted link check over all internal links in changed files — 0 broken among links introduced here (pre-existing /api-reference/... routes are Mintlify-generated, not plain files)

Cross-repo follow-ups (flashduty-website)

  • website_changelog (f010, medium): content/changelog/ newest entry is 2026-08-11; no website changelog entry for multi-time-zone support or RUM remote configuration. Suggest NEW: content/changelog/2026-09-02-timezone-support.mdx + .zh.mdx (frontmatter per the 341200 entry format). RUM remote config may wait until SaaS rollout widens.
  • website_integrations: no new/changed integrations in this window (fc-datasource slack-retry-classify is internal) — no action.

Mapping warnings

  • monit-webapi, monit-edge: not cloneable (repo not found under flashcatcloud, anonymous + authenticated). Monitors module analyzed from fc-foundation-app/src/Packages/monit only; its window diff was display-only time-zone plumbing — no findings expected but backend claims were unverified.
  • fc-foundation-app submodules resolved via HTTPS rewrite (no SSH in sandbox); saas/rum/monit/ai-sre all fetched at origin/main.

Skipped

  • Diff analysis re-run with --first-parent bases after the initial round silently swallowed in-window merges (rum #360, fc-oncall docs: remove Electron operation monitoring section #266, fc-safari #989, foundation-app #758); analysis above reflects the corrected diffs.
  • Content already covered by open PR docs: daily doc-review 2026-09-01 — heartbeat, AI SRE status page drafts, IM feedback + drift fixes #334 (silence-detection docs, AI SRE status-page drafts, IM feedback, incident-list default filter, batch 100 limit) — not duplicated here.
  • moment→dayjs / fmtInZone / zoneDay facade plumbing across all FE repos (display-only, no new user-visible controls).
  • flashduty-app quick-silence permission alignment (data-level authz consistency, no docs-level change).
  • fc-rum quota-key change session.free_cntsession_investigate.free_cnt (internal metering contract, not in public docs).
  • war-room member-lookup perf refactor (personcache).

Findings artefacts: .doc-review/findings-2026-09-02-084531.{yaml,json,html} (local).

…etail page, RUM remote configuration

- platform: org/personal/schedule time-zone settings (f002,f005) + member list time zone column
- platform: new member detail page (f003)
- rum: application remote configuration (sampling rates, privacy level, rules, versioning) (f001)
- on-call: incident list filter bar revamp — three-state assignment toggle (f004)
- ai-sre: on-prem public-share requires CDN base (f006)
- changelog: 2026-09-02 entry (f007-f009)
@debidong
debidong merged commit 41b7c31 into main Sep 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant