Skip to content

feat: add pre-commit hook file - #20

Closed
Botnic wants to merge 1 commit into
fischeti:mainfrom
Botnic:pre-commit-hook
Closed

Botnic wants to merge 1 commit into
fischeti:mainfrom
Botnic:pre-commit-hook

Conversation

@Botnic

@Botnic Botnic commented Nov 1, 2026 •

Copy link
Copy Markdown

Add a .pre-commit-hooks.yaml allowing to run the linter or only the checker.

By providing such a .pre-commit-hooks.yaml, the user can simplify the integration on its side

 - repo: https://github.com/fischeti/rdlfmt
   rev: 0.4.0
   hooks:
    - id: rdlfmt

Add a .pre-commit-hooks.yaml allowing to run the linter or only the
checker.
@Botnic

Botnic commented Nov 1, 2026

Copy link
Copy Markdown
Author

The question is if the language should be set to rust or better to python.

@fischeti

fischeti commented Nov 1, 2026

Copy link
Copy Markdown
Owner

The problem with both python and rust as language is that they will compile the binary (pyproject.toml uses maturin as a build system which will also revert to cargo install). This is rather slow and I would avoid it. The workaround usually is to create a separate repository which I have now done: https://github.com/fischeti/rdlfmt-pre-commit. This will pull the pre-compiled binaries directly from PyPI which is much faster to setup. Hence, your PR will be superseeded by #23, but nevertheless thanks for the PR!

@fischeti fischeti closed this Nov 1, 2026
@Botnic
Botnic deleted the pre-commit-hook branch November 2, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants