Skip to content

chore(deps-dev): upgrade chai and related plugins to ESM versions #3270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahirumaramba merged 6 commits into from
Oct 7, 2026
Merged

chore(deps-dev): upgrade chai and related plugins to ESM versions #3270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
60ebaf4
chore(deps-dev): upgrade chai and related plugins to ESM versions
lahirumaramba Oct 6, 2026
77307a8
chore(test): remove redundant @types/chai and centralize chai/registe…
lahirumaramba Oct 7, 2026
94445e6
chore(test): include chai/register-should in tsconfig for ts-node
lahirumaramba Oct 7, 2026
b63859a
chore(test): revert tsconfig.json and import chai/register-should in …
lahirumaramba Oct 7, 2026
606c22a
Merge remote-tracking branch 'origin/main' into lm-upgrade-chai
lahirumaramba Oct 7, 2026
aea3cf4
Merge branch 'main' into lm-upgrade-chai
lahirumaramba Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
155 changes: 50 additions & 105 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 6 additions & 7 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,7 @@
"@firebase/auth-types": "^0.13.1",
"@microsoft/api-extractor": "^7.11.2",
"@types/bcrypt": "^6.0.0",
"@types/chai": "^4.0.0",

@yvonnep165 yvonnep165 Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr description mentions upgrading @types/chai (^4.0.0 -> ^5.2.3) but it seems to remove it here without bumping?

@lahirumaramba lahirumaramba Oct 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, the review bot asked me to remove it haha
Thanks!

"@types/chai-as-promised": "^7.1.0",
"@types/chai-as-promised": "^8.0.2",
Comment thread
lahirumaramba marked this conversation as resolved.
Comment thread
lahirumaramba marked this conversation as resolved.
"@types/firebase-token-generator": "^2.0.28",
"@types/jsonwebtoken": "8.5.9",
"@types/lodash": "^4.14.104",
Expand All @@ -236,13 +235,13 @@
"@types/nock": "^11.1.0",
"@types/node": "^26.0.0",
"@types/sinon": "^22.0.0",
"@types/sinon-chai": "^3.0.0",
"@types/sinon-chai": "^4.0.0",
"@typescript-eslint/eslint-plugin": "^8.67.0",
"@typescript-eslint/parser": "^8.67.0",
"bcrypt": "^6.0.0",
"chai": "^4.2.0",
"chai-as-promised": "^7.0.0",
"chai-exclude": "^2.1.0",
"chai": "^6.2.2",
"chai-as-promised": "^8.0.2",
"chai-exclude": "^3.0.1",
"chalk": "^4.1.1",
"child-process-promise": "^2.2.1",
"eslint": "^10.3.0",
Expand All @@ -262,7 +261,7 @@
"nyc": "^18.0.0",
"run-sequence": "^2.2.1",
"sinon": "^22.0.0",
"sinon-chai": "^3.0.0",
"sinon-chai": "^4.0.1",
"ts-node": "^10.2.0",
"typescript": "^5.7.3",
"typescript-eslint": "^8.67.0"
Expand Down
3 changes: 2 additions & 1 deletion test/integration/app-check.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
import * as _ from 'lodash';
import { getAppCheck, AppCheckToken } from '../../lib/app-check/index';
import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import 'chai/register-should';
import chaiAsPromised from 'chai-as-promised';
import fs = require('fs');
import path = require('path');

Expand Down
5 changes: 3 additions & 2 deletions test/integration/auth.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import * as url from 'url';
import * as crypto from 'node:crypto';
import * as bcrypt from 'bcrypt';
import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import 'chai/register-should';
import chaiAsPromised from 'chai-as-promised';
import firebase from '@firebase/app-compat';
import '@firebase/auth-compat';
import { clone } from 'lodash';
Expand All @@ -35,7 +36,7 @@ import {
PasswordPolicyConfig, SmsRegionConfig, RecaptchaConfig, ActionCodeSettings,
} from '../../lib/auth/index';
import * as sinon from 'sinon';
import * as sinonChai from 'sinon-chai';
import sinonChai from 'sinon-chai';

const chalk = require('chalk');

Expand Down
3 changes: 2 additions & 1 deletion test/integration/data-connect.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
*/

import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import 'chai/register-should';
import chaiAsPromised from 'chai-as-promised';
import { getDataConnect, ConnectorConfig } from '../../lib/data-connect/index';
import firebase from '@firebase/app-compat';
import { apiKey, projectId } from './setup';
Expand Down
3 changes: 2 additions & 1 deletion test/integration/database.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
*/

import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import 'chai/register-should';
import chaiAsPromised from 'chai-as-promised';
import {
Database, DataSnapshot, EventType, Reference, ServerValue, getDatabase, getDatabaseWithUrl,
} from '../../lib/database/index';
Expand Down
3 changes: 2 additions & 1 deletion test/integration/firestore.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
*/

import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import 'chai/register-should';
import chaiAsPromised from 'chai-as-promised';
import { clone } from 'lodash';
import { getApp } from '../../lib/app/index';
import {
Expand Down
3 changes: 2 additions & 1 deletion test/integration/functions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
*/

import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import 'chai/register-should';
import chaiAsPromised from 'chai-as-promised';
import { getFunctions } from '../../lib/functions/index';

chai.should();
Expand Down
3 changes: 2 additions & 1 deletion test/integration/installations.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@

import { getInstallations } from '../../lib/installations/index';
import * as chai from 'chai';
import * as chaiAsPromised from 'chai-as-promised';
import 'chai/register-should';
import chaiAsPromised from 'chai-as-promised';

chai.should();
chai.use(chaiAsPromised);
Expand Down
Loading
Loading