Skip to content

docs(auth): update Screen Transitions samples to the Navigation 3 AuthUITransitions - #2475

Open
demolaf wants to merge 2 commits into
version-10.0.0-beta05from
fix/nav3-readme-transition-samples
Open

docs(auth): update Screen Transitions samples to the Navigation 3 AuthUITransitions#2475
demolaf wants to merge 2 commits into
version-10.0.0-beta05from
fix/nav3-readme-transition-samples

Conversation

@demolaf

@demolaf demolaf commented Sep 3, 2026

Copy link
Copy Markdown
Member

The Screen Transitions samples still use the Navigation 2 constructor — enterTransition / exitTransition / popEnterTransition / popExitTransition — which no longer exists, so none of the four compile. AuthUITransitions now takes one ContentTransform per direction: transitionSpec, popTransitionSpec and predictivePopTransitionSpec.

Rewrites the four samples against the new constructor, pairing each enter/exit with togetherWith, and adds a per-destination sample using the public Scene<NavKey>.authRoute(). The closing note now says each spec falls back to the default 700ms cross-fade independently — predictivePopTransitionSpec does not fall back to popTransitionSpec, and it fires when the gesture starts rather than when a back completes.

Compiled all five samples verbatim against the module to check they build.


Maintainer note: Fixes internal CPRN-404

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the auth/README.md documentation to reflect changes in screen transitions, moving from individual enter/exit transitions to unified transition specs using togetherWith. It also adds documentation for per-destination animations and updates notes on default transitions. Feedback is provided regarding an inconsistency in the vertical slide transition example, where the exit animation direction contradicts the accompanying comment.

Comment thread auth/README.md
@demolaf
demolaf marked this pull request as ready for review September 4, 2026 12:36
@demolaf
demolaf force-pushed the fix/nav3-readme-transition-samples branch from 48aee3c to 65e890b Compare September 4, 2026 12:54
@demolaf
demolaf changed the base branch from version-10.0.0-beta05 to feat/reauth-and-recovery-test-coverage September 4, 2026 12:54
@demolaf
demolaf marked this pull request as draft September 4, 2026 12:54
@demolaf
demolaf marked this pull request as ready for review September 4, 2026 13:01
Base automatically changed from feat/reauth-and-recovery-test-coverage to version-10.0.0-beta05 September 4, 2026 15:45
@russellwheatley
russellwheatley force-pushed the fix/nav3-readme-transition-samples branch from 65e890b to 97bbc01 Compare September 4, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant