Repository navigation
[ONB-4132] [Compose] Exponer split en suscripciones e invoices v2 - #41
Merged
FranciscaOtero merged 1 commit intoNov 2, 2026
Merged
Conversation
Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
Contributor
Author
|
fin review |
FranciscaOtero
marked this pull request as ready for review
October 31, 2026 12:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
La API pública ahora devuelve el
spliten las suscripciones v2 y elsplit+split_applieden las invoices v2, pero el SDK los descartaba.Origen: fintoc-rails #19791.
¿Qué hay de nuevo?
V2::Subscription#splitV2::Invoice#splityV2::Invoice#split_appliednilcuando no vienen en la respuestaTests
subscriptioneinvoicearmados desde el schema; sin cassettes nuevos)Safety Checks
Consideraciones
Revisé el resto de cambios de las specs (
main-api.jsonde fintoc-rails ycore-api.jsonde pacioli) entre el 2026-10-26 y el 2026-11-02 (fintoc-rails78e9e45→c4590b0, pacioli2aeaa93→23eb151) y ya estaban en el SDK:client.v2.recipientscreatereenvíaaccount_typeyholder_id, y los códigos de error de las respuestas 403/404 ya tienen su clase (MissingResourceError, etc.). Los nuevos valores decounterparty.account_type,institution.countryyreasonse exponen tal cual como stringsspliten payment intents v1 (fintoc-rails #19389)Quedó fuera, porque solo cambia documentación o validaciones del servidor y no el contrato del SDK:
payment_method_types: ["card"]y rango demax_amount(fintoc-rails #19637, #19392)mandate_limit_exceeded,merchant_volume_limit_exceeded,payment_method_inactive; ya tienen su clase) (fintoc-rails #18918, #19390)Rollback
Es seguro hacer rollback, solo hay que revertir la PR.
🤖🐙 Created with Compose · View session