Skip to content

[BA-8923] [Compose] Alinear SDK con verificaciones de cuentas en Chile y split en payment intents - #39

Merged
FranciscaOtero merged 4 commits into
mainfrom
compose/align-public-api-7d9a
Oct 29, 2026
Merged

FranciscaOtero merged 4 commits into
mainfrom
compose/align-public-api-7d9a

Conversation

@FranciscaOtero

@FranciscaOtero FranciscaOtero commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Contexto

La API pública ya permite verificar cuentas en Chile y devuelve el split en los payment intents, pero el SDK no lo soportaba.

Origen: pacioli #3877, fintoc-rails #19389 y #18918.

¿Qué hay de nuevo?

  • Se pueden verificar cuentas chilenas: account_verifications.create acepta institution_id, account_type y holder_id
  • V2::PaymentIntent expone split y split_applied
  • Errores MandateLimitExceededError y MaximumAmountLimitError, que antes llegaban como FintocError genérico
  • Ejemplo en el README

Tests

  • Tests unitarios

Consideraciones

  • Recipients, transfer batches, payment_methods.cancel y los eventos transfer_batch.* ya estaban en el SDK
  • Dejé el filtro 'status[]' de transfer batches como estaba: con status: [...], el server solo recibe un valor

🤖🐙 Created with Compose · View session

@FranciscaOtero FranciscaOtero added the agent:compose PR created by Compose AI agent label Oct 29, 2026
@FranciscaOtero FranciscaOtero self-assigned this Oct 29, 2026
@fin-hermes fin-hermes Bot added the size/M label Oct 29, 2026
@FranciscaOtero FranciscaOtero changed the title [BA-8923] [Compose] [Compose] Alinear SDK con verificaciones de cuentas en Chile y split en payment intents [BA-8923] Alinear SDK con verificaciones de cuentas en Chile y split en payment intents Oct 29, 2026
@FranciscaOtero FranciscaOtero changed the title [BA-8923] Alinear SDK con verificaciones de cuentas en Chile y split en payment intents [BA-8923] [Compose] Alinear SDK con verificaciones de cuentas en Chile y split en payment intents Oct 29, 2026
@fin-compose
fin-compose Bot force-pushed the compose/align-public-api-7d9a branch from 793934b to fe6234d Compare October 29, 2026 20:03
@fin-hermes fin-hermes Bot added the risk:high label Oct 29, 2026
FranciscaOtero and others added 4 commits October 29, 2026 20:06
La API pide institution_id, account_type y holder_id para verificar cuentas en Chile, y create solo mandaba account_number.

Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
La API los devuelve siempre y el resource los descartaba.

Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
Sin la clase, mandate_limit_exceeded llegaba como FintocError genérico.

Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
check_eligibility responde maximum_amount_limit_error y llegaba como FintocError genérico.

Co-authored-by: fin-compose[bot] <255610621+fin-compose[bot]@users.noreply.github.com>
@fin-compose
fin-compose Bot force-pushed the compose/align-public-api-7d9a branch from fe6234d to 42de580 Compare October 29, 2026 20:06
@FranciscaOtero
FranciscaOtero marked this pull request as ready for review October 29, 2026 20:07
@fin-hermes
fin-hermes Bot requested a review from daleal October 29, 2026 20:07

@fin-review fin-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@FranciscaOtero
FranciscaOtero merged commit 8ed8b29 into main Oct 29, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:compose PR created by Compose AI agent risk:high size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants