Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades the app to Laravel 13 / Laravel Zero 13.x, Pest v4, and adds PHP 8.5 to the CI matrix.
Important
Draft until Laravel Zero tags a stable 13.x release. Laravel Zero currently only has a
dev-feature/13.x-upgradebranch (no stable tag), solaravel-zero/frameworkandlaravel-zero/foundationare pinned todev-feature/13.x-upgrade as 13.0.0. Once v13 is tagged, swap both constraints to^13.0and re-runcomposer updatebefore marking ready for review.Changes
illuminate/encryption^12.0→^13.0(13.20.0)laravel-zero/framework/laravel-zero/foundation→dev-feature/13.x-upgrade as 13.0.0(see note above)pestphp/pest^3.8→^4.0(4.7.5), migratedphpunit.xml.distoff the deprecated schema^8.2→^8.3(required by both Laravel 13 and Pest 4)[8.5, 8.4, 8.3]laravel/pintto^1.25andnunomaduro/termwindto^2.4, applied new Pint fixesbuilds/padlockphar as 5.0.0 (major bump due to the PHP floor change)Workaround
The Laravel Zero 13.x branch's test lifecycle unconditionally calls
FormRequest::flushState(), butFormRequestdepends onilluminate/httpandilluminate/validation, which Laravel Zero strips out. Both are added as dev-only dependencies (not bundled in the phar). They can likely be removed once this is fixed upstream or the stable release lands.Test plan
./vendor/bin/pestpasses on PHP 8.5env:encrypt→env:decryptround-trip via bothphp padlockand the rebuilt pharPadlock 5.0.0and runs without deprecation warnings on PHP 8.5