Repository navigation
Fix the Windows desktop app build and installer - #37
Merged
Merged
Conversation
The wrapper always prepended C:\msys64, but GitHub's Windows runners ship an MSYS2 there while release-app installs its own elsewhere. The release build ended up mixing the two installs, so tools handed across re-parsed their command lines Windows-style (globs expanded, backslashes dropped). libtool's find then dropped libcnary from libplist-2.0.a and the Windows app build has failed since at least v0.5.9. Complete the MSYS2 install already on PATH instead, and only fall back to MSYS2_ROOT or C:\msys64 when there isn't one.
Quoting the find patterns didn't stop *.o being expanded before find saw it (v0.5.11 and v0.5.12 failed the same way), so libplist-2.0.a kept shipping without libcnary. The extraction dir only holds what ar x just unpacked, so swap the patterns for -type f and leave nothing to glob. Left alone elsewhere since BSD ar also extracts __.SYMDEF.
…2Loader.dll Without it, tauri CLI 2.11.4 hands the bundler its own -msvc triple, so the NSIS step that adds WebView2Loader.dll for -gnu builds is skipped and the installed app can't start (#21). Also check the installer for the DLL in the release job, and use the same flag in just app-build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows desktop build has failed since ~v0.5.8 (libplist-2.0.a built without libcnary, then
undefined reference to node_*downstream), and when it did build, the installer was missing WebView2Loader.dll (#21).C:\msys64. Mixing the runner's MSYS2 with the one release-app installs is what made tools re-parse their command lines Windows-style.-type finstead of-name \*.oglobs, so there's nothing left to expand.--target x86_64-pc-windows-gnuso the bundler adds WebView2Loader.dll, and fail the job if the installer doesn't contain it.release-app only runs on tags, so the real test is the next release.