Repository navigation
Conversation
The probe runs in Lima's persistent SSH session, opened before provisioning adds the user to the docker group, so as the user docker info kept answering permission denied until the timeout while the daemon had been up for minutes. Three up runs in a row failed on it on 2026-11-20, one with a 25-minute timeout. cmd_up's restart still gives the user its own access.
php.ini now reads sendmail_path = "${MADOCK_SENDMAIL_PATH}" in every project
and the compose file gives each PHP service the value (msmtp with
php/sendmail/host, port and from, or the system sendmail when off). The mail
settings used to be written into the image, which made that line the first
difference between a template and its muted clone: the clone rebuilt every
layer after it, and no two clones shared them.
Host, port and sender become a command PHP runs through /bin/sh, so they are
checked before the image is written. Unit tests were broken four ways (sender
back in the Dockerfile, variable out of compose, host check reduced to
non-empty, value computed before the muted-clone rule) and each failed; the
e2e TestPhpImageIsTheSameWhateverTheMailSettings fails with the sender back in
the Dockerfile: 28 layers, shared prefix 17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP's
sendmail_pathnow comes from the container's environment, so the php image no longer depends on where mail goes.sendmail_path = "${MADOCK_SENDMAIL_PATH}"in every project; the compose file gives the value to php, php without Xdebug, workers and the Shopware/Sylius messengers.php/sendmail/host,portandfrom, or/usr/sbin/sendmail -t -iwhenphp/sendmail/enabledis false. Computed last in the derived rules, after the muted-clone rule and extensions./bin/sh); a bad value is refused with the key named.Tests:
TestPhpImageDoesNotDependOnTheMailSettings(render): fails with the sender back in the Dockerfile and with the variable taken out of compose.TestSendmailRefusesWhatIsNotAHostAPortOrAnAddress: fails with the host check reduced to non-empty.TestMutedCloneSendmailPathIsTheMutedOne: fails with the value computed before the muted-clone rule.TestPhpImageIsTheSameWhateverTheMailSettings: two projects with different mail share all 28 layers, CLI and php-fpm each read their own value, a defaultmail()arrives in mailpit, a sender change needs no new image. Passed on a fresh VM (289 s); with the sender back in the Dockerfile it fails: 28 and 28 layers, shared prefix 17.Also: the e2e VM's docker readiness probe asks the daemon as root. It ran in Lima's persistent SSH session opened before the user joined the docker group and timed out on
permission deniedthree runs in a row.4.5.68.