Skip to content

Shared proxy: server_tokens off; 4.5.67 - #268

Merged
faradey merged 2 commits into
masterfrom
staging
Nov 19, 2026
Merged

faradey merged 2 commits into
masterfrom
staging

Conversation

@faradey

@faradey faradey commented Nov 19, 2026

Copy link
Copy Markdown
Owner

The shared proxy answered every request and error page with Server: nginx/<version>. Its http block now sets server_tokens off. Upstream Server headers are hidden by proxy_pass, so one line covers every project. Takes effect on madock proxy:rebuild.

Golden proxy fixtures updated; with the line removed, the three proxy golden tests fail.

Every response and error page from the proxy said Server: nginx/<version>.
The http block now sets server_tokens off. Upstream Server headers are
hidden by proxy_pass, so this covers every project behind the proxy.

Broke it: with the line removed, TestGoldenProxyConf,
TestGoldenProxyWithTwoProjects and TestGoldenProxyConfWithoutPublishedPorts
fail wanting 'server_tokens off;'.
@faradey faradey added the full-e2e Run the whole end-to-end suite and Platforms on this pull request label Nov 19, 2026
The proxy drops upstream Server headers, but the body of nginx's own error
page passes through and named the version. The shared nginx Dockerfile
snippet writes server_tokens off into conf.d, covering every platform.

Broke it: with the snippet line removed, TestGoldenPlatformStacks fails
for every platform's nginx.Dockerfile.
@faradey
faradey merged commit e7a2e75 into master Nov 19, 2026
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-e2e Run the whole end-to-end suite and Platforms on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant