Repository navigation
Conversation
Every response and error page from the proxy said Server: nginx/<version>. The http block now sets server_tokens off. Upstream Server headers are hidden by proxy_pass, so this covers every project behind the proxy. Broke it: with the line removed, TestGoldenProxyConf, TestGoldenProxyWithTwoProjects and TestGoldenProxyConfWithoutPublishedPorts fail wanting 'server_tokens off;'.
The proxy drops upstream Server headers, but the body of nginx's own error page passes through and named the version. The shared nginx Dockerfile snippet writes server_tokens off into conf.d, covering every platform. Broke it: with the snippet line removed, TestGoldenPlatformStacks fails for every platform's nginx.Dockerfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared proxy answered every request and error page with
Server: nginx/<version>. Itshttpblock now setsserver_tokens off. UpstreamServerheaders are hidden byproxy_pass, so one line covers every project. Takes effect onmadock proxy:rebuild.Golden proxy fixtures updated; with the line removed, the three proxy golden tests fail.