Repository navigation
Conversation
The project used to be stopped first and the images built afterwards by up --build, so it was down for the whole build: about eleven minutes for a live Laravel project on 2026-11-17. prepare now runs docker compose build (with the cache, or without it for --no-cache) while the old containers run; up --build then finds every layer built. A failed build stops nothing and exits 1. Version 4.5.65. Proved by breaking: with the build taken out of prepare, TestWithoutNoCacheTheImagesAreStillBuiltFirst and TestAFailedBuildCarriesNothing fail, and the e2e TestAFailedBuildLeavesTheProjectRunning fails with the app container gone after the rebuild; with --pull added to the build arguments, TestBuildImagesIsTheBuildUpWouldRun fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rebuild stopped the project first and built the images afterwards inside up --build, so the project was down for the whole build: about eleven minutes for a live Laravel project on 2026-11-17 while its php image was rebuilt from a slow package mirror.