Skip to content

rebuild builds the images before it takes the containers down (4.5.65) - #266

Merged
faradey merged 1 commit into
masterfrom
staging
Nov 17, 2026
Merged

faradey merged 1 commit into
masterfrom
staging

Conversation

@faradey

@faradey faradey commented Nov 17, 2026

Copy link
Copy Markdown
Owner

A rebuild stopped the project first and built the images afterwards inside up --build, so the project was down for the whole build: about eleven minutes for a live Laravel project on 2026-11-17 while its php image was rebuilt from a slow package mirror.

  • prepare now runs docker compose build (with the cache; without it for --no-cache, as before) while the old containers still run. up --build afterwards finds every layer built, and the outage is the recreate.
  • A build that fails stops nothing: Build failed, nothing was stopped, exit 1.
  • New e2e TestAFailedBuildLeavesTheProjectRunning breaks the build through .madock/docker/Dockerfile and checks app, db and nginx were not restarted. Passes on this branch (231 s on a VM); fails on the old order with the app container gone.
  • Version 4.5.65.

The project used to be stopped first and the images built afterwards by
up --build, so it was down for the whole build: about eleven minutes for
a live Laravel project on 2026-11-17. prepare now runs docker compose
build (with the cache, or without it for --no-cache) while the old
containers run; up --build then finds every layer built. A failed build
stops nothing and exits 1. Version 4.5.65.

Proved by breaking: with the build taken out of prepare,
TestWithoutNoCacheTheImagesAreStillBuiltFirst and
TestAFailedBuildCarriesNothing fail, and the e2e
TestAFailedBuildLeavesTheProjectRunning fails with the app container
gone after the rebuild; with --pull added to the build arguments,
TestBuildImagesIsTheBuildUpWouldRun fails.
@faradey faradey added the full-e2e Run the whole end-to-end suite and Platforms on this pull request label Nov 17, 2026
@faradey
faradey merged commit 9a2c50e into master Nov 17, 2026
28 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-e2e Run the whole end-to-end suite and Platforms on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant