Skip to content

Majordomo compatibility improvements - #387

Merged
RalphSteinhagen merged 2 commits into
mainfrom
majordomoFixes
Dec 10, 2025
Merged

Majordomo compatibility improvements#387
RalphSteinhagen merged 2 commits into
mainfrom
majordomoFixes

Conversation

@wirew0rm

@wirew0rm wirew0rm commented Dec 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This fixes a minor inconsistency by adding vector<string> which looks like it was an oversight that it wasn't defined.

It also fixes the CI workflow which was using a sonarcloud github action which does not exist anymore. I've updated the workflow, but there is still some issue with the sonarcloud integration, but this could also be fixed separately i guess.

Originally this PR had some more changes, which where ultimately then fixed more consistently on the java side.

@wirew0rm
IoSerialiserYaS: allow vector<string>
78428b6 
Vector of string/string_view were missing from the allowed types,
only allowing bare c-style arrays of strings.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 10:39 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 10:39 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 10:39 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 10:39 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 10:39 — with GitHub Actions Inactive
@wirew0rm wirew0rm mentioned this pull request Dec 9, 2025
Closed
2 tasks done
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 15:42 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 15:42 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 15:42 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 15:42 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 15:42 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 15:42 — with GitHub Actions Inactive
@wirew0rm
Fix Sonarcube action
cad3cee 
The repository for the action has moved and it now uses
compile_commands.json by default.

Also bump the other action versions to the current versions.

Signed-off-by: Alexander Krimm <A.Krimm@gsi.de>
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 17:30 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 17:30 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 17:30 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 17:30 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 17:30 — with GitHub Actions Inactive
@wirew0rm
wirew0rm temporarily deployed to configure coverage December 9, 2025 17:30 — with GitHub Actions Inactive
@wirew0rm
wirew0rm marked this pull request as ready for review December 9, 2025 17:33
@sonarqubecloud

sonarqubecloud Bot commented Dec 9, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots
E Reliability Rating on New Code (required ≥ A)
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

RalphSteinhagen
RalphSteinhagen approved these changes Dec 10, 2025
View reviewed changes

@RalphSteinhagen RalphSteinhagen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@RalphSteinhagen
RalphSteinhagen merged commit b5b3537 into main Dec 10, 2025
9 of 10 checks passed
@RalphSteinhagen
RalphSteinhagen deleted the majordomoFixes branch December 10, 2025 08:54

This branch was previously deployed

1 inactive deployment
configure coverage — cad3cee8 Deployed Dec 9, 2025 by wirew0rm via ubuntu-22.04 emscripten | Debug #1217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalphSteinhagen RalphSteinhagen RalphSteinhagen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wirew0rm @RalphSteinhagen