Decouple metric fetch errors from trial status in Orchestrator - #5287
Open
saitcakmak wants to merge 1 commit into
Open
saitcakmak wants to merge 1 commit into
saitcakmak wants to merge 1 commit into
Conversation
Summary: Keep trial execution status authoritative to runner polling when metric fetching fails. Orchestrator now leaves completed trials completed, uses MetricAvailability to count incomplete optimization-config data in the existing failure-rate policy, and handles expanded multi-metric result keys without assuming they are registered experiment metrics. This mirrors the behavior core Ax already has in the Orchestrator. This implements the core design from the abandoned RFC D98741656 and fixes T287759832. Differential Revision: D119207750
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119207750. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5287 +/- ##
==========================================
+ Coverage 96.57% 96.59% +0.01%
==========================================
Files 621 621
Lines 70912 70911 -1
==========================================
+ Hits 68481 68494 +13
+ Misses 2431 2417 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Keep trial execution status authoritative to runner polling when metric fetching fails. Orchestrator now leaves completed trials completed, uses MetricAvailability to count incomplete optimization-config data in the existing failure-rate policy, and handles expanded multi-metric result keys without assuming they are registered experiment metrics.
This mirrors the behavior core Ax already has in the Orchestrator.
This implements the core design from the abandoned RFC D98741656 and fixes T287759832.
Differential Revision: D119207750