chore: redo and update grade-school tests - #1040
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| @@ -9,83 +11,177 @@ | |||
|
|
|||
| using namespace std; | |||
There was a problem hiding this comment.
Pulling an entire namespace in is considered bad practice. I believe we do this in many places today, but what do you think about changing it and updating this test while you're at it?
There was a problem hiding this comment.
I'm with you; normally, I critique this as well. Being so far away from the track, I need to be reminded of the basics from time to time. Thanks for the nits!
| TEST_CASE("a_new_school_has_an_empty_roster") { | ||
| TEST_CASE("roster_is_empty_when_no_student_is_added", | ||
| "[a3f0fb58-f240-4723-8ddc-e644666b85cc]") { | ||
| const grade_school::school school_{}; |
There was a problem hiding this comment.
The trailing underscore here and in other places look odd. Using them only for class/struct members makes sense, but for local variables I would remove them. Wdyt?
2 participants
@Elahi-cs already did some of the work, but we never finished. So this is a clean slate that supersedes #920.