Repository navigation
fix: deploy.sh pulls fresh base images, so runtime security fixes arrive - #284
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/deploy.shbuilt with plaindocker compose build, so Docker reused thenode:22-alpineit cached at the first install and runtime security fixes never reached a deployment. When Node 22.23.4 stopped trusting the roots of the compromised eMudhra certificate authority (October 2026), deployments kept running 22.23.2 and 22.23.3.docker compose build --pull, and pulls the image-only services:db, and the TLS proxy where it is started.postgres:16-alpinestays on its pinned major; the database container is recreated when a newer 16.x patch image arrives (a restart of a few seconds, data volume untouched).Verified: shellcheck (v0.9.0, as CI) and prettier clean. Run on a real deployment: the build re-resolved
node:22-alpine, pulled the database image, the containers came back healthy on Node 22.23.4 with the data intact, and the database moved to Postgres 16.15. The offline fallback was exercised with a stubbeddockerthat fails the pull: it warns and falls back to the cached build.