Repository navigation
Conversation
✅ Deploy Preview for eslint-code-explorer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Mode-specific parsing and regression test src/hooks/use-ast.ts, e2e-tests/code-editing-and-ast-interaction.test.ts |
JSON parsing passes allowTrailingCommas only in JSONC mode. The test checks that JSON mode displays the expected parse error for a trailing comma. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Possibly related PRs
- eslint/code-explorer#594: PR
#594relocates the JSON parsing branch that this change modifies.
Suggested reviewers: lumirlumir
Merge Risk: 
Minimal · up to f20ee
-
No actionable merge-blocking risk was identified; the change addresses the reported JSON parsing behavior.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 2 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Prerequisites checklist
AI acknowledgment
What is the purpose of this pull request?
This PR fixes a bug where JSON mode accepts trailing commas if Allow Trailing Commas was turned on in JSONC mode.
Steps to reproduce
json.{"foo":"bar",}.What changes did you make? (Give an overview)
Passed
allowTrailingCommasto the parser only in JSONC mode.Related Issues
Is there anything you'd like reviewers to focus on?
Summary by CodeRabbit