Audit fixes (2026-09) - #6
Merged
Merged
Conversation
…p.worker] config; CI SECURITY (P0): reset the current-user identity per request. current_user (and the legacy user_ID/userdata/... globals) were never cleared, so a logged-in request pinned its identity onto the resident worker and the next anonymous visitor was seen as that user. Add them to RESET_GLOBALS so resetRequestGlobals() unsets them and WordPress re-derives the user from this request's fresh $_COOKIE. Add RequestIsolationTest proving request N (logged-in) does not leak into N+1. P1: marshalSuperglobals() only ever ASSIGNED $_SERVER keys, so per-request vars (HTTP_AUTHORIZATION, CONTENT_TYPE/LENGTH, HTTP_X_*) bled across requests. Track adapter-set keys and unset the ones a later request does not re-supply. Add an absent-key bleed test. - nested $_FILES for multipart name[] uploads (pivoted shape; was last-wins). Add splitFieldName()/assignByPath() + multi-file test. - README: fix the broken (new Worker(...))->run() one-liner (Worker has no run(); the loop lives in bin/ephpm-wp-worker) and point users at the entry script. - migrate ephpm.toml + e2e/app.toml + docs to [php.worker] (script/max_requests/ boot_timeout/populate_superglobals) and [php] concurrency; flat worker_* keys are now a hard startup error. - add GitHub Actions CI (composer install + phpunit on PHP 8.2/8.3/8.4)
|
ePHPm Preview — removed Preview deployment has been torn down. |
|
ePHPm Preview — deployed (health check pending)
Preview updates automatically on each push to this PR. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audited fixes for wordpress-worker (see per-repo details). Config-key migration to
[php.worker](ePHPm #462, the old flat keys are hard startup errors), multipartname[]upload fix where applicable, request-isolation/security fixes for wordpress-worker, and CI (phpunit on PHP 8.2/8.3/8.4). Tests added for every behavioral/security change. wordpress-worker's podman e2e must be re-run manually.