Skip to content

deps/ci: Fix release dates when a module is updated - #49408

Open
phlax wants to merge 1 commit into
envoyproxy:mainfrom
phlax:deps-release-dates-updater
Open

phlax wants to merge 1 commit into
envoyproxy:mainfrom
phlax:deps-release-dates-updater

Conversation

@phlax

@phlax phlax commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

The dependency bot (ci/dependency/update.sh) bumps a bazel_dep and leaves the release_date of the dependency in deps.yaml as it was. The hook that updated it for the WORKSPACE updater went with WORKSPACE (#47217), so every bump since has had a stale date (#49388 needed six fixed by hand), and now that the release dates check is back (#48705) the deps precheck of a bump fails on it.

This adds //tools/dependency:release_dates (release_date_updater, envoyproxy/toolshed#5626 and envoyproxy/toolshed#5630), which fixes the dates in bazel/deps.yaml and api/bazel/deps.yaml with the ones that the checker (//tools/dependency:check) looks up:

$ bazel run //tools/dependency:release_dates -- gperftools
Checking the release dates of: gperftools
bazel/deps.yaml: gperftools 2026-03-06 -> 2026-10-21

deps.update (the bot's bazel task) and registry with named modules (its registry task) now run it for the modules they update. Only those are looked up, as each is a request to GitHub, a module can be named as the module (msgpack-c) where its metadata key differs (msgpack-cxx), and a module with no metadata is skipped. It needs the GITHUB_TOKEN that the workflow already gives the update.

Not covered: registry with all, where the updated modules are not known at that point; their dates are left to the deps check.

A dependency with metadata in both files (envoy_toolshed) is fixed in both: the check reads the API file's date.

Risk Level: Low (dependency tooling only)
Testing: The bazel task was run from a branch with these changes against a pre-release of the toolshed module (run 44363626118, gperftools msgpack-c, no PR): the diff it produced has the gperftools date fixed alongside the MODULE.bazel and lockfile changes. There the step was in do_ci.sh; it is now in deps_update. The registry path, and the fix of a dependency in both files (toolshed 0.5.26.envoy, #49411), have not been run.
Docs Changes: ci/README.md
Release Notes: N/A

@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #49408 was opened by phlax.

see: more, trace.

The dependency bot (`ci/dependency/update.sh`) bumped a `bazel_dep`
and left the `release_date` of the dependency in `deps.yaml` as it
was: the hook that updated it went with WORKSPACE (envoyproxy#47217). Since the
release dates check came back (envoyproxy#48705) that fails the `deps` precheck
of the bump.

`//tools/dependency:release_dates` (envoyproxy/toolshed#5626) fixes
the dates in `bazel/deps.yaml` and `api/bazel/deps.yaml` with the ones
that the checker looks up. `deps.update` and `registry` now run it for
the modules that they update. Only those are looked up, as each is a
request to GitHub, and a module with no metadata is skipped.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
phlax force-pushed the deps-release-dates-updater branch from a6313b3 to 601a946 Compare November 18, 2026 20:35
@phlax phlax changed the title [WIP] deps/ci: Fix release dates when a module is updated deps/ci: Fix release dates when a module is updated Nov 18, 2026
@phlax
phlax marked this pull request as ready for review November 18, 2026 20:35
@phlax
phlax requested a balanced review from Copilot November 18, 2026 20:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant