Repository navigation
Conversation
phlax
force-pushed
the
deps-release-dates-updater
branch
from
November 18, 2026 20:18
7c7a109 to
a6313b3
Compare
The dependency bot (`ci/dependency/update.sh`) bumped a `bazel_dep` and left the `release_date` of the dependency in `deps.yaml` as it was: the hook that updated it went with WORKSPACE (envoyproxy#47217). Since the release dates check came back (envoyproxy#48705) that fails the `deps` precheck of the bump. `//tools/dependency:release_dates` (envoyproxy/toolshed#5626) fixes the dates in `bazel/deps.yaml` and `api/bazel/deps.yaml` with the ones that the checker looks up. `deps.update` and `registry` now run it for the modules that they update. Only those are looked up, as each is a request to GitHub, and a module with no metadata is skipped. Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
deps-release-dates-updater
branch
from
November 18, 2026 20:35
a6313b3 to
601a946
Compare
phlax
marked this pull request as ready for review
November 18, 2026 20:35
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dependency bot (
ci/dependency/update.sh) bumps abazel_depand leaves therelease_dateof the dependency indeps.yamlas it was. The hook that updated it for the WORKSPACE updater went with WORKSPACE (#47217), so every bump since has had a stale date (#49388 needed six fixed by hand), and now that the release dates check is back (#48705) thedepsprecheck of a bump fails on it.This adds
//tools/dependency:release_dates(release_date_updater, envoyproxy/toolshed#5626 and envoyproxy/toolshed#5630), which fixes the dates inbazel/deps.yamlandapi/bazel/deps.yamlwith the ones that the checker (//tools/dependency:check) looks up:deps.update(the bot'sbazeltask) andregistrywith named modules (itsregistrytask) now run it for the modules they update. Only those are looked up, as each is a request to GitHub, a module can be named as the module (msgpack-c) where its metadata key differs (msgpack-cxx), and a module with no metadata is skipped. It needs theGITHUB_TOKENthat the workflow already gives the update.Not covered:
registrywithall, where the updated modules are not known at that point; their dates are left to thedepscheck.A dependency with metadata in both files (
envoy_toolshed) is fixed in both: the check reads the API file's date.Risk Level: Low (dependency tooling only)
Testing: The
bazeltask was run from a branch with these changes against a pre-release of the toolshed module (run 44363626118,gperftools msgpack-c, no PR): the diff it produced has thegperftoolsdate fixed alongside theMODULE.bazeland lockfile changes. There the step was indo_ci.sh; it is now indeps_update. Theregistrypath, and the fix of a dependency in both files (toolshed 0.5.26.envoy, #49411), have not been run.Docs Changes:
ci/README.mdRelease Notes: N/A