Repository navigation
Conversation
…yproxy#49375) CVE-2026-130065 is a heap buffer overflow in `msgpack_vrefbuffer_migrate()` (`src/vrefbuffer.c`) of msgpack-c through 7.0.2: the capacity check compares against the source array's end pointer, so migrating between vrefbuffers of unequal size can skip the realloc and write past the destination array. Envoy uses the header-only C++ library (`msgpack-cxx` 7.0.0), so the C file is not built. The C++ `msgpack::vrefbuffer::migrate()` has the same check (`include/msgpack/v1/vrefbuffer.hpp`), but it is not reachable: the only msgpack users are the fluentd access logger and tracer, which pack into `msgpack::sbuffer` (`source/extensions/common/fluentd/fluentd_base.h`). Nothing in `source/` or `contrib/` uses a `vrefbuffer`. The CVE scan on `main` reports it (alongside the OpenSSL 3.5.9 ones, which this does not address). As for CVE-2026-72854 (envoyproxy#49052). Risk Level: Low (CVE scan config only) Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: Ryan Northey <ryan@synca.io>
0.4.13.post5 has, backported to the WORKSPACE line (envoyproxy/toolshed#5623), a `cve_scan` that does not need the scanner's `RunEnvironmentInfo`. With Bazel 7 an `sh_binary` does not provide it, so the CVE scan failed at analysis there (as it does on `release/v1.38`); with Bazel 8 nothing changes. Signed-off-by: Ryan Northey <ryan@synca.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CVE scan of
release/v1.38, which fails at analysis rather than scanning (run 44302440200):envoy_toolshed-> 0.4.13.post5. The WORKSPACE line of toolshed, with bazel/dependency/cve: Work out the scan and fetch toolenvin the rules toolshed#5623:cve_scanno longer needs the scanner'sRunEnvironmentInfo, which ansh_binarydoes not provide with Bazel 7 (this branch is on 7.7.1;release/v1.39, with the same toolshed but Bazel 8.7.0, scans). As [WIP] [bp/1.39] deps: Bumpenvoy_toolshed-> 0.4.13.post5, CVE exclude, an RBE pool pin and ext_proc fuzzer fix #49393 forrelease/v1.39.msgpack-c7.0.0, same packing-only fluentd users.Testing: the scan was run from this branch with
envoy_toolshedpinned to the toolshed fix before its release (run 44307144491): it analyses, scans, and reports nine findings, this msgpack one and eight for OpenSSL 3.5.9. Those eight remain after this PR; they are fixed in 3.5.10, which is not yet released upstream.