Skip to content

[WIP] [bp/1.38] deps: Bump envoy_toolshed -> 0.4.13.post5, and a CVE exclude - #49394

Draft
phlax wants to merge 2 commits into
envoyproxy:release/v1.38from
phlax:bp-1.38-toolshed-cve
Draft

phlax wants to merge 2 commits into
envoyproxy:release/v1.38from
phlax:bp-1.38-toolshed-cve

Conversation

@phlax

@phlax phlax commented Nov 18, 2026

Copy link
Copy Markdown
Member

Fixes the CVE scan of release/v1.38, which fails at analysis rather than scanning (run 44302440200):

ERROR: tools/dependency/BUILD:118:9: in _scanned rule //tools/dependency:cves.scanned:
Error: <target //tools/dependency:cves> (rule 'sh_binary') doesn't contain declared provider 'RunEnvironmentInfo'

Testing: the scan was run from this branch with envoy_toolshed pinned to the toolshed fix before its release (run 44307144491): it analyses, scans, and reports nine findings, this msgpack one and eight for OpenSSL 3.5.9. Those eight remain after this PR; they are fixed in 3.5.10, which is not yet released upstream.

phlax and others added 2 commits November 18, 2026 14:57
…yproxy#49375)

CVE-2026-130065 is a heap buffer overflow in
`msgpack_vrefbuffer_migrate()` (`src/vrefbuffer.c`) of msgpack-c through
7.0.2: the capacity check compares against the source array's end
pointer, so migrating between vrefbuffers of unequal size can skip the
realloc and write past the destination array.

Envoy uses the header-only C++ library (`msgpack-cxx` 7.0.0), so the C
file is not built. The C++ `msgpack::vrefbuffer::migrate()` has the same
check (`include/msgpack/v1/vrefbuffer.hpp`), but it is not reachable:
the only msgpack users are the fluentd access logger and tracer, which
pack into `msgpack::sbuffer`
(`source/extensions/common/fluentd/fluentd_base.h`). Nothing in
`source/` or `contrib/` uses a `vrefbuffer`.

The CVE scan on `main` reports it (alongside the OpenSSL 3.5.9 ones,
which this does not address). As for CVE-2026-72854 (envoyproxy#49052).

Risk Level: Low (CVE scan config only)
Testing: N/A
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Ryan Northey <ryan@synca.io>
0.4.13.post5 has, backported to the WORKSPACE line
(envoyproxy/toolshed#5623), a `cve_scan` that does not need the
scanner's `RunEnvironmentInfo`. With Bazel 7 an `sh_binary` does not
provide it, so the CVE scan failed at analysis there (as it does on
`release/v1.38`); with Bazel 8 nothing changes.

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only

Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #49394 was opened by phlax.

see: more, trace.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant