Repository navigation
Conversation
Signed-off-by: Boteng Yao <botengyao@gmail.com>
KBaichoo
previously approved these changes
Nov 17, 2026
KBaichoo
left a comment
Contributor
There was a problem hiding this comment.
Can you add the regression test that proves this doesn't work for upstream retries?
| Upstream HTTP Filter Support | ||
| ---------------------------- | ||
|
|
||
| The decompressor filter can also be configured as an upstream HTTP filter, for example in the |
Contributor
There was a problem hiding this comment.
Can you also add for now that it's broken for retries since that'll be extremely confusing to debug?
Signed-off-by: Boteng Yao <botengyao@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: decompressor: support use as an upstream HTTP filter. The decompressor filter can now be configured in the router's or a cluster's upstream HTTP filter chain, matching the compressor filter (#46490).
Additional Description:
The filter only reads and rewrites headers, body and trailers, which the upstream filter manager already supports. So the change is the upstream factory registration plus the
envoy.filters.http.upstreamcategory, withstatus_upstream: alphaas for the compressor. The existing integration suite now runs every case twice: with the filter in the HCM chain, and in the cluster's upstream HTTP filter chain.Known limitation, shared with the upstream compressor: upstream filters edit the router's request header map in place, and the router does not restore it before a retry. A retry resends a copy of the original buffered body. So after request-direction decompression on the first try,
content-encodinghas already been removed. The retried request then carries the still-compressed body without that header. This needs a fix in the router rather than in each filter, so it is not addressed here.