Skip to content

Bugs in piston #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LudwigBoess wants to merge 5 commits into
base: 1.5.0rc
Choose a base branch
from
Open

Bugs in piston #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3349f5c
pass is_left through to CrossesPiston so a right-facing wall can reus…
LudwigBoess Aug 21, 2026
523c401
bugfix in conductor BCs
LudwigBoess Aug 21, 2026
1aa6ee9
Turn inline Lambda into proper kernel to avoid NVidia compilation error
LudwigBoess Aug 21, 2026
33ac2eb
revert conductor BC normal-B fix, preserved on bug/conductor_bcs_norm…
LudwigBoess Sep 21, 2026
06996c5
Merge branch '1.5.0rc' into bug/conductor_piston
LudwigBoess Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 57 additions & 26 deletions src/archetypes/moving_window.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,54 @@ namespace arch {
}
};

#if defined(MPI_ENABLED)
/**
* @brief Assigns MPI send tags from the particle cell indices.
* @note Particles outside the active domain get the tag of the neighbor they belong to.
*/
template <Dimension D>
struct PrtlRetag_kernel {
array_t<int*> i1, i2, i3;
array_t<short*> tag;
const int ni1, ni2, ni3;

PrtlRetag_kernel(const array_t<int*>& i1,
const array_t<int*>& i2,
const array_t<int*>& i3,
const array_t<short*>& tag,
int ni1,
int ni2,
int ni3)
: i1 { i1 }
, i2 { i2 }
, i3 { i3 }
, tag { tag }
, ni1 { ni1 }
, ni2 { ni2 }
, ni3 { ni3 } {}

Inline void operator()(prtlidx_t p) const {
if constexpr (D == Dim::_1D) {
tag(p) = mpi::SendTag(tag(p), i1(p) < 0, i1(p) >= ni1);
} else if constexpr (D == Dim::_2D) {
tag(p) = mpi::SendTag(tag(p),
i1(p) < 0,
i1(p) >= ni1,
i2(p) < 0,
i2(p) >= ni2);
} else if constexpr (D == Dim::_3D) {
tag(p) = mpi::SendTag(tag(p),
i1(p) < 0,
i1(p) >= ni1,
i2(p) < 0,
i2(p) >= ni2,
i3(p) < 0,
i3(p) >= ni3);
}
}
};
#endif // MPI_ENABLED

/**
* @brief Updates particle position and fields in the moving window.

Expand Down Expand Up @@ -213,32 +261,15 @@ namespace arch {
: 0;
for (auto s { 0u }; s < nspec; ++s) {
auto& species = domain.species[s];
auto i1 = species.i1;
auto i2 = species.i2;
auto i3 = species.i3;
auto tag = species.tag;
Kokkos::parallel_for(
"RetagWindowParticles",
species.rangeActiveParticles(),
Lambda(prtlidx_t p) {
if constexpr (M::Dim == Dim::_1D) {
tag(p) = mpi::SendTag(tag(p), i1(p) < 0, i1(p) >= ni1);
} else if constexpr (M::Dim == Dim::_2D) {
tag(p) = mpi::SendTag(tag(p),
i1(p) < 0,
i1(p) >= ni1,
i2(p) < 0,
i2(p) >= ni2);
} else if constexpr (M::Dim == Dim::_3D) {
tag(p) = mpi::SendTag(tag(p),
i1(p) < 0,
i1(p) >= ni1,
i2(p) < 0,
i2(p) >= ni2,
i3(p) < 0,
i3(p) >= ni3);
}
});
Kokkos::parallel_for("RetagWindowParticles",
species.rangeActiveParticles(),
PrtlRetag_kernel<M::Dim>(species.i1,
species.i2,
species.i3,
species.tag,
ni1,
ni2,
ni3));
}

#endif
Expand Down
6 changes: 4 additions & 2 deletions src/archetypes/piston.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ namespace arch {
* @param piston_position Position of the piston at the start of timestep in global coordinates
* @param piston_v Velocity of piston at current timestep
* @param massive Whether the particle is massive or massless (e.g. photon)
* @param is_left Is piston on the left side of the box or right side of the box
*/
template <CartesianMetricClass M>
Inline void Piston(prtlidx_t p,
Expand All @@ -88,10 +89,11 @@ namespace arch {
const M& metric,
real_t piston_position,
real_t piston_v,
bool massive) {
bool massive,
bool is_left = true) {

// check if particle actually crosses the piston, if not return
if (!CrossesPiston<M>(p, dt, particles, metric, piston_position, piston_v, true)) {
if (!CrossesPiston<M>(p, dt, particles, metric, piston_position, piston_v, is_left)) {
return;
}
// step 1: calculate the particle 3 velocity
Expand Down
Loading