diff_order_for_section_name warning instead of crash - #407
Draft
HaydnTrigg wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Is there any scenario where a left symbol will be paired to a right symbol but that right symbol will not be paired to a left symbol? That doesn't sound correct to me and I believe it would cause a number of subtle issues in other parts of objdiff which assume that symbols are paired both ways, which is why I intentionally made it crash here instead of ignoring the bug and incorrectly showing no diff. A crash is more likely to be reported as a bug than a warning. Actually, where does objdiff even log to, anyway? I've only seen its warnings in the console when running it in debug mode, which most users won't see at all and won't be able to report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f2f813e added in a function diff_order_for_section_name which crashes out with the error message
Failed to find right side symbol for paired left side symbolThis change makes this function log a warning instead of crashing out and also provides context for the expected symbol name and section that is expected.
v3.8.1:

v3.7.1:

Patched:
