Repository navigation
Add Japanese, Chinese, and French translations with a topbar language switcher - #2
Merged
Merged
Conversation
… switcher
Introduce bin/i18n.py: a per-request-thread translation lookup keyed by the
English source string, with catalogs in bin/locales/{ja,zh,fr}.json. The
dashboard resolves the language from a loop_lang cookie, then
Accept-Language, then English, and renders every page, flash message, and
inline script string through _t(). A translate-icon menu in the topbar sets
the cookie and reloads.
tests/test_i18n.py checks that every _t() literal in bin/web has an entry
in each catalog with matching format placeholders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/i18n.py: per-request-thread translation lookup keyed by the English source string; catalogs inbin/locales/{ja,zh,fr}.json(~580 strings each).loop_langcookie →Accept-Language→ English.<html lang>set accordingly._t().CLAUDE.mddocuments the_t()convention for new UI strings.Intentionally left in English: product names, user/config data, log output, and the chat suggestion prompts (they are sent to the AI).
Testing
python3 -m pytest tests/ -q→ 1829 passed, 15 xfailed, 2 xpassed.tests/test_i18n.pyenforces that every_t()literal has an entry in all three catalogs with matching{placeholders}; English output is unchanged.