[fengzeroz]

No description provided.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T02:59:05.242522Z	de1eec7	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 94.79866% with 62 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.16%. Comparing base (ef6b3ff) to head (29155c4).

Files with missing lines	Patch %	Lines
src/persist/sqlite.c	91.09%	17 Missing ⚠️
src/base/property.c	77.46%	16 Missing ⚠️
src/parser/neu_json_node.c	93.43%	9 Missing ⚠️
tests/ut/node_property_persist_test.cc	97.86%	8 Missing ⚠️
src/core/manager.c	87.27%	7 Missing ⚠️
plugins/restful/adapter_handle.c	92.59%	2 Missing ⚠️
src/adapter/driver/cache.c	91.66%	2 Missing ⚠️
plugins/restful/rest.c	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2948      +/-   ##
==========================================
+ Coverage   65.22%   66.16%   +0.93%     
==========================================
  Files         129      133       +4     
  Lines       32468    33738    +1270     
==========================================
+ Hits        21178    22322    +1144     
- Misses      11290    11416     +126     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de1eec7cd9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Point the persistence test at the committed migration

When node_property_persist_test runs under the added CTest target, SetUp tries to copy persistence/0123_2.16.0_node_properties.sql, but a repo-wide search of this commit's tracked files finds only persistence/0160_2.16.1_node_properties.sql. std::filesystem::copy_file therefore fails before neu_persister_create, so every test in this new suite fails; align the fixture and migration filenames.

Useful? React with 👍 / 👎.

[chatgpt-codex-connector]

Preserve last-good attributes while filtering errors

When NEURON_SUB_FILTER_ERROR is enabled and a good sample is followed by a filtered NEU_TYPE_ERROR, control jumps to error_not_report but this line still replaces the good sample's attributes with the error's typically empty attributes. Reads then pair the retained good value with the wrong quality/timestamp, and the next identical good sample is falsely treated as a quality change (the added filtered_error_compares_last_good_quality test hits this path); keep the last-good attributes when the error is filtered.

Useful? React with 👍 / 👎.