Repository navigation
Preserve Monero wallet error messages across the C++ bridge - #1216
Merged
Merged
Conversation
Deploying eigenwallet-docs with
|
| Latest commit: |
5bf5b34
|
| Status: | ⚡️ Build in progress... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FfiWallet::check_errorread the original empty Rust string afterstatusWithErrorStringpopulated a separate C++ string. Wallet failures therefore reportedunknown error, error not setinstead of their actual cause.Read the populated C++ string and add a regression test that passes an invalid transaction ID to the real wallet without requiring a running daemon. The test fails with the old implementation and passes with this fix. Includes a changelog entry.
Validation:
cargo test -p monero-sys --test wallet_errorpassed; confirmed failure before the fix.cargo c --all-features,cargo c --tests, andcargo c --all-targetspassed.git diff --checkpassed. Formatting checks report pre-existing differences in untouched code; no formatting differences are reported for the changed error handling or new test.Implemented with Codex assistance.