Repository navigation
feat: name the packaged mltbx from MltbxFileName in MLToolboxInfo.json - #80
Merged
Merged
Conversation
A non-empty top-level MltbxFileName field in MLToolboxInfo.json sets the file name of the packaged toolbox, with ".mltbx" appended when it is missing. It takes precedence over ToolboxShortName. Without the field the name stays <ToolboxName>_v<version>.mltbx. A fixed name lets the latest release be downloaded from a stable releases/latest/download/<name>.mltbx link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Test Results111 tests 110 ✅ 34s ⏱️ Results for commit ac6952c. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 57.08% 57.31% +0.22%
==========================================
Files 68 68
Lines 1820 1846 +26
==========================================
+ Hits 1039 1058 +19
- Misses 781 788 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createToolboxOptionsnames the packaged toolbox<ToolboxName>_v<version>.mltbx, so every release asset has a different file name and there is no stable download link for the latest release.This adds an optional top-level
MltbxFileNamefield toMLToolboxInfo.json. When it is set and non-empty, it is used as the file name, with.mltbxappended if missing, and it takes precedence over theToolboxShortNameoption. A name that contains/or\raisesMatBox:Package:InvalidMltbxFileName, because the file is always written toreleases/. When the field is absent or empty, the name is built as before.With a fixed name, the latest release can be downloaded from
https://github.com/<owner>/<repo>/releases/latest/download/<MltbxFileName>.mltbx.The matbox-actions workflows need no change: the release, codemeta and verification steps all read the file name from
mltbx_path.Docs: README packaging section,
docs/ci.mdand thepackageToolboxhelp text describe the field.🤖 Generated with Claude Code