fix(infra): run queryRaw over stored JSON, not Encoded - #904
Merged
Merged
Conversation
Memory, SQLite, and Postgres queryRaw used Store.all, which JSON→Encoded decodes Date/Map/Set. Repository.queryRaw then applies toCodecJson and fails with Expected JSON value. Feed parseRow/allStored JSON instead. Cosmos already queried JSON and is unchanged. Co-authored-by: Patrick Roza <42661+patroza@users.noreply.github.com>
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After Encoded
Date/Map/Set, Memory and SQLitequeryRawstill ran overStore.all, which JSON→Encoded-decodes every document.Repository.queryRawthen appliestoCodecJsonto the projector output, so wrapping aDatefield asS.Unknownfails withExpected JSON value at [0]. That is the Mako rehearsal crash:orderRepo.queryRaw(S.Unknown, makeRawRowsQuery(ids)).What
Memory, SQLite, and Postgres
queryRawnow project stored JSON (allStored/parseRow) instead of decodedall. Cosmos already queried JSON and is unchanged.all/findstill decode Encoded.How
queryRawuses existingallStored(JSON in the Ref).queryRawmapsparseRowwithoutmakeStoredDecode.queryRaw(S.Unknown, { id, raw })test on Memory and SQLite.query.sql/ adapter-specific SQL is a follow-up, not this PR.Remarks
Design angles: assumed goal is queryRaw JSON contract so jitM/raw loaders see stored documents — peers Memory.filter (
allStoredthen decode) and SQLparseRow(undecoded row mapper); CosmosqueryRawalready JSON. Follow those. Follow-up:query.sqldefault + pg/sqlite SQL later.After merge: Version PR → release → scanner + configurator consume the new versions → Mako rehearsal → then decide whether Mako should stay on
makeRawMigrationStoreor others can go back to typed-repoqueryRaw.opened by patroza in chat thread Discord · Discord · T3
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.