Repository navigation
eval: root cache keys on the shape under a rigid placement (posed assemblies re-render from cache) - #929
Merged
Conversation
The placement is applied to the cached mesh, so a posed assembly in a new pose hits the cache instead of re-running every boolean. Two-arm scenario frame (242 roots): ~100 s -> 0.3 s per frame once the shapes are cached. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A mesh bundle written from root_keys can't stand in for a placed shape, so a root whose rigid placement was peeled off the cache key reports None. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ecto
changed the title
ecto
force-pushed
the
render-photoreal-gpu
branch
from
October 16, 2026 17:46
198ddf2 to
516466d
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root mesh cache: key a root on its shape, not its placement.
When a root is a rigid
Translate/Rotatechain over a shape, the cache now keys on the shape underneath and applies the placement to the cached mesh afterwards. A posed assembly rendered in a new pose is then all cache hits instead of re-running every boolean.Workload: a two-arm robot scene from rose. 242 roots, about 280 bolt-hole booleans, each plate emitted as
[translate [rotate shape]].Measured with
vcad export frame.loon frame.glbon top of current main.Details
peel_rigid_placementstrips the outer Translate/Rotate chain (bails on Scale) and reusescollect_transform_chainfor the composed transform.place_meshmaps positions and normals. It only applies when a cache is configured; uncached evaluation is unchanged.Solidgets the same transform, so BRep consumers see the placed solid.root_keys: a peeled root reportsNone, because a mesh bundle written from its key would be the unplaced shape. Those parts simply aren't bundled.Scope change
This PR first carried a GPU mesh tracer and photoreal look changes (cyclorama backdrop, edge rounding, finishes) inside
vcad-kernel-raytrace. Main has since moved the tracer into kosm-render, which already has a GPU path, so that work will come back as a kosm-render PR instead. It's preserved on the local branchrender-gpu-look.Verification
rigid_placement_is_peeled_off_the_cache_key: one cube placed twice gives 1 miss and 1 hit, both copies land at their own placements, androot_keysis[None, None].cargo test --release -p vcad-evalpasses.cargo fmtandcargo clippyare clean on the touched file.🤖 Generated with Claude Code