Skip to content

fix(featureflags): default per-sandbox connection limits to a finite cap #3813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdaAibaby wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(featureflags): default per-sandbox connection limits to a finite cap #3813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions packages/shared/pkg/featureflags/flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,12 +880,16 @@ var (
PauseResumePrefetchHarvestTimeoutMsFlag = NewIntFlag("pause-resume-prefetch-harvest-timeout-ms", 15000) // 15s

// TCPFirewallMaxConnectionsPerSandbox is the maximum number of concurrent TCP firewall
// connections allowed per sandbox. Negative means no limit.
TCPFirewallMaxConnectionsPerSandbox = NewIntFlag("tcpfirewall-max-connections-per-sandbox", -1)
// connections allowed per sandbox. Negative means no limit. The default is a
// generous finite cap so a deployment with no LaunchDarkly override still bounds
// per-sandbox egress connections (see #3681); operators raise or disable it per team.
TCPFirewallMaxConnectionsPerSandbox = NewIntFlag("tcpfirewall-max-connections-per-sandbox", 1024)

// SandboxMaxIncomingConnections is the maximum number of concurrent HTTP proxy
// connections allowed per sandbox. Negative means no limit.
SandboxMaxIncomingConnections = NewIntFlag("sandbox-max-incoming-connections", -1)
// connections allowed per sandbox. Negative means no limit. The default is a
// generous finite cap so a deployment with no LaunchDarkly override still bounds
// per-sandbox ingress connections (see #3681); operators raise or disable it per team.
SandboxMaxIncomingConnections = NewIntFlag("sandbox-max-incoming-connections", 1024)

// BuildBaseRootfsSizeLimitMB is the maximum size of the base rootfs filesystem created from the OCI image, in MB.
BuildBaseRootfsSizeLimitMB = NewIntFlag("build-base-rootfs-size-limit-mb", 25000)
Expand Down