Update JsonSchema.Net.Generation to 5.0.4 - #7702
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward, centrally-managed dependency version bump with no additional code or API surface modifications.
Pull request overview
Updates the centralized dependency version used by ML.NET’s build to consume JsonSchema.Net.Generation 5.0.2 (while keeping JsonSchema.Net pinned at 7.3.4), avoiding the previously-unlisted 5.0.1 package in future releases.
Changes:
- Bump
JsonSchema.Net.Generationversion property from 5.0.1 to 5.0.2. - Leave
JsonSchema.Netversion property unchanged at 7.3.4.
File summaries
| File | Description |
|---|---|
| eng/Versions.props | Updates the MSBuild version property used by central package management for JsonSchema.Net.Generation to 5.0.2. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
JsonSchema.Net.Generation 5.0.2 is more than a year old. I guess we don't want to make big updates to dependency versions right now, but would it be worth updating to at least 5.0.4? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7702 +/- ##
=======================================
Coverage 69.88% 69.88%
=======================================
Files 1487 1487
Lines 276253 276253
Branches 28291 28291
=======================================
+ Hits 193053 193056 +3
+ Misses 75710 75705 -5
- Partials 7490 7492 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Summary
Update
JsonSchema.Net.Generationfrom 5.0.1 to 5.0.4. KeepJsonSchema.Netat 7.3.4.Version 5.0.1 was unlisted because it declared an incorrect minimum dependency of
JsonSchema.Net1.0.0. Version 5.0.2 corrected that dependency to 7.3.4. See json-everything/json-everything#894.Use 5.0.4, as suggested in review, to also include the fixes for properties hidden with the C#
newkeyword (5.0.3) and schema-definition name collisions (5.0.4). Version 5.0.4 supports the same target frameworks and requires the same minimum dependency versions as 5.0.2. See the upstream release notes.The published ML.NET GenAI packages already require
JsonSchema.Net7.3.4 or later. This change removes the unlisted dependency from future releases.Validation
src/Microsoft.ML.GenAI.Mistral/Microsoft.ML.GenAI.Mistral.csprojwith its dependencies: 0 warnings and 0 errors.JsonSchema.Net.Generation5.0.4 andJsonSchema.Net7.3.4.Microsoft.ML.GenAI.Mistral0.24.0-preview.26457.2 and Generation 5.0.4 on macOS ARM64 with .NET 10.0.11. Confirmed that the loaded Generation assembly reports version 5.0.4. Both existing prompt scenarios, with and without tools, match their repository approval baselines. The prompt-builder source is unchanged from the published release.git diff --checkpassed.These are targeted build and runtime checks, not a full GenAI test-suite run.