Skip to content

Update JsonSchema.Net.Generation to 5.0.4 - #7702

Merged
matouskozak merged 2 commits into
mainfrom
matouskozak-jsonschema-net-generation-pre-release
Sep 10, 2026
Merged

Update JsonSchema.Net.Generation to 5.0.4#7702
matouskozak merged 2 commits into
mainfrom
matouskozak-jsonschema-net-generation-pre-release

Conversation

@matouskozak

@matouskozak matouskozak commented Sep 9, 2026

Copy link
Copy Markdown
Member

Summary

Update JsonSchema.Net.Generation from 5.0.1 to 5.0.4. Keep JsonSchema.Net at 7.3.4.

Version 5.0.1 was unlisted because it declared an incorrect minimum dependency of JsonSchema.Net 1.0.0. Version 5.0.2 corrected that dependency to 7.3.4. See json-everything/json-everything#894.

Use 5.0.4, as suggested in review, to also include the fixes for properties hidden with the C# new keyword (5.0.3) and schema-definition name collisions (5.0.4). Version 5.0.4 supports the same target frameworks and requires the same minimum dependency versions as 5.0.2. See the upstream release notes.

The published ML.NET GenAI packages already require JsonSchema.Net 7.3.4 or later. This change removes the unlisted dependency from future releases.

Validation

  • Built src/Microsoft.ML.GenAI.Mistral/Microsoft.ML.GenAI.Mistral.csproj with its dependencies: 0 warnings and 0 errors.
  • Confirmed that restore resolves JsonSchema.Net.Generation 5.0.4 and JsonSchema.Net 7.3.4.
  • Used an isolated console runner with published Microsoft.ML.GenAI.Mistral 0.24.0-preview.26457.2 and Generation 5.0.4 on macOS ARM64 with .NET 10.0.11. Confirmed that the loaded Generation assembly reports version 5.0.4. Both existing prompt scenarios, with and without tools, match their repository approval baselines. The prompt-builder source is unchanged from the published release.
  • git diff --check passed.

These are targeted build and runtime checks, not a full GenAI test-suite run.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 9, 2026 13:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a straightforward, centrally-managed dependency version bump with no additional code or API surface modifications.

Pull request overview

Updates the centralized dependency version used by ML.NET’s build to consume JsonSchema.Net.Generation 5.0.2 (while keeping JsonSchema.Net pinned at 7.3.4), avoiding the previously-unlisted 5.0.1 package in future releases.

Changes:

  • Bump JsonSchema.Net.Generation version property from 5.0.1 to 5.0.2.
  • Leave JsonSchema.Net version property unchanged at 7.3.4.
File summaries
File Description
eng/Versions.props Updates the MSBuild version property used by central package management for JsonSchema.Net.Generation to 5.0.2.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@svick

svick commented Sep 9, 2026

Copy link
Copy Markdown
Member

JsonSchema.Net.Generation 5.0.2 is more than a year old. I guess we don't want to make big updates to dependency versions right now, but would it be worth updating to at least 5.0.4?

@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.88%. Comparing base (2fc13ba) to head (b7552c4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7702   +/-   ##
=======================================
  Coverage   69.88%   69.88%           
=======================================
  Files        1487     1487           
  Lines      276253   276253           
  Branches    28291    28291           
=======================================
+ Hits       193053   193056    +3     
+ Misses      75710    75705    -5     
- Partials     7490     7492    +2     
Flag Coverage Δ
Debug 69.88% <ø> (+<0.01%) ⬆️
production 64.07% <ø> (+<0.01%) ⬆️
test 89.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@matouskozak matouskozak changed the title Update JsonSchema.Net.Generation to 5.0.2 Update JsonSchema.Net.Generation to 5.0.4 Sep 9, 2026
@matouskozak
matouskozak merged commit 7b76e69 into main Sep 10, 2026
27 checks passed
@matouskozak
matouskozak deleted the matouskozak-jsonschema-net-generation-pre-release branch September 10, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants