Retain SOS dumps from failed Helix work items - #6050
Merged
Merged
Conversation
Retain all SOS harness dumps when a Helix work item fails so intermittent failures can be investigated after the machine is released. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2d5c60f7-9c89-42e6-b9fc-04ef78c8f8d8
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Ensure dump archiving also occurs when signature restoration fails.
Review effort: Lite
Findings: None
What changed in this PR
Adds failure-only SOS dump archiving for Helix work items on Windows and Unix, with documentation updates.
Changes:
- Archives SOS dumps after launcher failures.
- Preserves passing-work-item behavior.
- Documents retained failure artifacts.
| File | Reviewed changes |
|---|---|
src/tests/SOS.Tests/README.md |
Documents Helix dump retention. |
src/tests/SOS.Tests/Helix/run-sos-tests.sh |
Archives Unix SOS dumps on failure. |
src/tests/SOS.Tests/Helix/run-sos-tests.cmd |
Archives Windows SOS dumps on failure. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
steveisok
approved these changes
Sep 21, 2026
max-charlamb
deleted the
dev/max-charlamb/retain-sos-dumps-on-failure
branch
September 21, 2026 14:18
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Windows x86 SOS failure in #6047 analyzed
argslocals.dmp, but that input dump was stored only in the work item's scratch directory. Existing failure diagnostics retain dumps when a debugger host crashes; they do not retain the input dump when the host completes normally and the test later fails an assertion.The failure did not reproduce in 1,100 fresh local x86 captures, so retaining the complete dump set from a failed leg gives us the evidence needed to investigate rare collection or ICorDebug failures after Helix releases the machine.
The failing CI run was https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=1601946&view=logs&jobId=c72c5e66-de89-5f4b-8ef9-fd893b8f7646.
Validation
dumps/sample.dmpbash -n src/tests/SOS.Tests/Helix/run-sos-tests.sh