Handle createdump race during self-collection - #6042
Merged
Merged
Conversation
Apply the existing .NET 8 and 9 Linux createdump permission-race skip to self-collected snapshots, and capture both child output streams for classification and diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 2d5c60f7-9c89-42e6-b9fc-04ef78c8f8d8
steveisok
approved these changes
Sep 16, 2026
max-charlamb
enabled auto-merge (squash)
September 16, 2026 20:21
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed changes are covered by tests and no blocking issues were identified.
Pull request overview
Updates SOS snapshot capture to handle known .NET 8/9 Linux createdump permission races during crash and self-collection.
Changes:
- Shares permission-race detection across capture paths.
- Drains and reports both output streams.
- Updates validity tests for skip behavior.
File summaries
| File | Description |
|---|---|
src/tests/SOS.Tests/TestConfigValidityTests.cs |
Verifies supported and unsupported skip conditions. |
src/tests/SOS.TestHarness/SnapshotStore.cs |
Applies shared race handling and captures both output streams. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
/ba-g osx timeout |
max-charlamb
disabled auto-merge
September 16, 2026 21:13
This was referenced Sep 16, 2026
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
src/tests/SOS.Tests/SOS.Tests.csprojin ReleaseTestConfigValidityTestsdirectly through the xUnit v3 runner: 23 passedCI failure
Addresses the Alpine dump collection failure in build 1598637, result 100330:
This is the runtime race fixed by dotnet/runtime#120000 for newer runtimes, but .NET 8 and 9 remain affected.