Repository navigation
WinGet publish action not hit because of default GitHub token #970
Description
Description of the issue
I see a new release was created v0.24.0-beta.3 but the WinGet publish action was not invoked.
Cause
This repo creates release automatically using an action
The action uses the default secrets.GITHUB_TOKEN created automatically. As I've found in these threads below, GitHub won't let that workflow trigger another workflow if the default github token is used.
- https://github.com/orgs/community/discussions/54574#discussioncomment-10119733
- https://github.com/orgs/community/discussions/25281#discussioncomment-3247262
To fix this, I would suggest changing the token in create-release.yml file to be a personal access token instead of an automatically generated one
Activity
waldekmastykarz commentedon Jan 24, 2025
We noticed this too and were just about to ping you. Thanks for reaching out @mdanish-kh! We were wondering what's the cause was for the workflow not to fire and arrived at the same conclusion. Unfortunately, using PATs is discouraged at Microsoft. As such, we won't be changing our workflow and for the time being, we'll stick to our existing process of publishing to winget manually. That said, thank you so much for working with us. I learned a thing or two and will keep it in mind for the future.
mdanish-kh commentedon Jan 24, 2025
@waldekmastykarz Ah, understandable. In that case, I'll close this issue. Feel free to ping me if you got anything else, thanks