Do not fail a successful install on a busy dmg - #40
Merged
Merged
Conversation
Installing on macOS fails with exit 16 when the volume is still busy right after install: dmg installed hdiutil: couldn't unmount "disk6" - Resource busy Error: Process completed with exit code 16 Desktop is installed and the settings have already been copied out by that point, so the run is lost to cleanup alone. Something still holds the volume open for a moment after the installer finishes. Retry the detach, then force it, and warn rather than fail if it still will not go. A mount left behind is recoverable: the caller that mounts into a workspace path force unmounts and removes it before its next install, and on an ephemeral runner the machine is discarded anyway. Failing the step here is not recoverable. Signed-off-by: Cesar Talledo <cesar.talledo@docker.com>
ctalledo
force-pushed
the
fix-dmg-detach
branch
from
September 10, 2026 18:32
3934745 to
ddcf463
Compare
mat007
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing on macOS fails with exit 16 when the volume is still busy right after install:
Desktop is installed and the settings have already been copied out by that point, so the run is lost to cleanup alone.
Retries the detach, then forces it, and warns rather than fails if it still will not go. A mount left behind is recoverable — a caller that mounts into a workspace path force unmounts and removes it before its next install, and on an ephemeral runner the machine is discarded anyway. Failing the step here is not.