Repository navigation
Add sentence fill-in mode to Der Die Das - #254
Merged
Merged
Conversation
✅ Deploy Preview for goofy-brahmagupta-0a14f0 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The article game currently practises noun gender only. Add a Sentences mode for completing German sentences with the correct article, including den, dem and des.
Validation:
npm run test:der-die-daspasses in GitHub Actions: 16 Node tests and all 17 browser tests, including the original game and the new sentence mode. The article-layout/site regression job also passes. JavaScript syntax, HTML IDs/labels/script order and git diff checks pass locally.