Skip to content

Fix search bar contrast in light and dark mode - #253

Merged
djeada merged 3 commits into
masterfrom
fix/search-theme-contrast
Oct 31, 2026
Merged

djeada merged 3 commits into
masterfrom
fix/search-theme-contrast

Conversation

@djeada

@djeada djeada commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner

The lazy-loaded Google search widget could retain provider colors, and highlighted suggestions explicitly used nearly black text on a dark background. Apply the existing theme tokens to the input, placeholder, search and clear icons, autocomplete rows (including Google's current keyboard-selection markup), result text, sort label, pagination, empty/error messages, and the Google search link. Rebuild the shared stylesheet so every page receives the fix.

Validation:

  • Checked the fallback input, loaded Google widget, keyboard-selected suggestions, and live search results in both themes on the Netlify preview, including theme changes after loading.
  • Audited 100 rendered result text elements per theme: minimum contrast 5.48:1 in light mode and 6.10:1 in dark mode, with no failures below 4.5:1. Selected dark suggestions improve from 1.24:1 to 12.95:1.
  • Generated CSS exactly matches the source assets; git diff --check passes.

@netlify

netlify Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for goofy-brahmagupta-0a14f0 ready!

Name Link
🔨 Latest commit ca2eaa6
🔍 Latest deploy log https://app.netlify.com/projects/goofy-brahmagupta-0a14f0/deploys/6ae66479644a48a9f4384ff4
😎 Deploy Preview https://deploy-preview-253--goofy-brahmagupta-0a14f0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@djeada
djeada merged commit 79fcd7e into master Oct 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant