Repository navigation
Restore historical V1/V2 leaderboard scores and labels - #7
Merged
Merged
Conversation
- Added rulesVersion field to score submissions and leaderboard entries. - Updated tests to validate behavior with multiple rules versions. - Implemented scoring eras to categorize scores based on rules versions. - Enhanced UI to display scores with corresponding rules versions. - Refactored score handling to accommodate legacy and current rules versions. - Ensured backward compatibility for historical scores and submissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Time currently filters scores to the active rules version, so verified V1 scores disappear after the V2 upgrade. Restore the existing V1/V2 implementation from
85d058b4c9968255302955086ec500f3774546d7onfeature/gameplay-improvements, recovered after inspecting the working tree, stashes, local branches and reflogs. That commit was absent frommain; it is cherry-picked here as0e450a6.Validation passed:
npm run build(client and Node replay engine) andnpm --prefix server run typecheck.node scripts/historical-leaderboard.mjs: real isolated local Worker/D1 plus Chromium; mixed-era ordering/counts/exclusions, historical detail ranks, V1/V2 labels, comparison note, YOU highlight, legacy personal-best refresh and a genuinely verified V2 submission with consistent ranks. Desktop and phone screenshots inspected. Available throughnpm run test:feature -- history.No production data migration, rewrite or reset is needed: existing rows already store
scores.rules_version, and the focused checks use the unchanged schema. No production database operations or deployments were performed.After review and explicit release approval, the existing CI pipeline on
maindeploys/verifies the Worker before publishing Pages from the same commit. This PR runs validation only; it does not merge or deploy.