Repository navigation
Feature/privacy play ux - #11
Merged
Merged
Conversation
main's merge commit has the same tree as 549729f, so this changes no files; it makes main an ancestor of dev again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- build.gradle: remove the five blank lines 8a55e73 added inside the unsigned-release guard (file is byte-identical to before that commit). - inspect-android-release.ps1: both modes refuse a debuggable APK and report the version; without -Unsigned it now requires verified APK (apksigner) and AAB (jarsigner) signatures, refuses the Android debug certificate, and refuses bundled draft privacy text, listing every problem before failing. -Unsigned only warns about the draft text. New -ApkPath/-AabPath to inspect copies. - androidRelease.test.ts: the inspector's marker list must cover every upper-case draft marker still in src/ui/menu/pages/privacy.ts. No gameplay, rules, server or packaged web change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- release-preflight: new "Current status (2026-11-12)" section separating verified items, confirmed internal-testing blockers and manual gates; older Stage 1/2 and blocker text marked as dated records. - Record read-only cron evidence: one successful 07:00 UTC invocation per day 2026-11-05..12 with 0 errors since c2aef78f, prune effects in D1. - Privacy draft, data inventory, backend, moderation, validation, Android and Play docs: stop describing reporting/moderation/erasure as undeployed; the policy text and contact remain unapproved drafts. - New phaser-asteroids/docs/phone-test-checklist.md (absorbs the old android.md device checklist): sideload build, install commands and sections for install, orientation, touch, audio, offline, ranked, retry, report/block/privacy and existing-install compatibility. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The draft-marker test passed a possibly undefined capture group to toContain's message, which tsc rejects. npm run build (and every suite that builds first, e.g. test:worker) failed at the typecheck step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
After the unchanged daily cleanup, the scheduled handler sends one short email when the console's Needs review queue is not empty (or open reports just expired unreviewed). It carries counts by reason, integrity flags, expiring/expired report counts and the /admin link; no names, score IDs, reporter/IP hashes or replay data. It never changes moderation state. - Delivery via Resend's HTTPS API with fetch (no new dependency). Disabled until RESEND_API_KEY, MODERATION_DIGEST_FROM/TO and MODERATION_DASHBOARD_URL are all set; disabled path touches no table. - Migration 0005 (additive) adds moderation_digests: one atomically claimed row per UTC day of scheduledTime, storing the text so every retry resends the same payload under one Idempotency-Key. 3 claims a day, one immediate retry for transient errors, 10-minute lease for abandoned sends, permanent errors wait for the next day. - Digest errors are caught (API key redacted); cleanup always runs first and a cleanup failure still fails the invocation. - pruneReports keeps the 30-day rule and now reports how many deleted reports were still open. - Production vars: recipient privacy@davidandrea.ca and the console URL only. Sender and API key are not configured. Tests: digest.test.ts (19), workerd e2e with a loopback mock provider, and an additive-0005 stage in the release migration rehearsal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… readiness - Public privacy/security/removal/appeal contact privacy@davidandrea.ca in the in-game Privacy screen, the policy draft, Play release notes and the operator guide. The DRAFT marker stays: the policy is still unapproved and the signed-release inspector keeps refusing it. - Draft states the confirmed default: verified scores are kept indefinitely, subject to moderation, removal requests and later storage policy. - Operator guide: digest behaviour, configuration and activation steps; report retention analysis with options A-D for an owner decision; Google Play UGC readiness rechecked 2026-11-12 (not established). - Data inventory, release preflight, backend doc and README pointers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ublished) Add phaser-asteroids/public/privacy/index.html (standalone, no scripts or third-party resources), point the offline privacy screens at it, extend pages-check and add a content guard test. Record facts, open questions and publish steps in docs/privacy-policy-publication.md. Package ID unchanged; the offline DRAFT marker stays until approval. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…c-rc Integrate the prepared (unpublished) Hull & Havoc privacy page b7385e8 on top of the moderation digest work. No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Title screen header, page/Phaser title, touch rotate prompt, Android launcher label and activity title, Capacitor appName and the operator console title. Package ID ca.davidandrea.spacearcade, Worker, D1, URLs, internal window.__ASTEROIDS_*__ hooks and the ASTEROIDS_UPLOAD_* signing variables are unchanged. No gameplay or scoring change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… text Open reports deleted at the 30-day limit were announced only in that day's digest. If that day's delivery failed or was abandoned mid-send, the next day started fresh and the notice was lost for good, because the reports were already deleted. Each ledger row now records the expired count it announces (0005 gains `expired` and a 'superseded' status; 0005 is unapplied in production). The next day's digest adds the counts of undelivered earlier days and marks those rows superseded, so nothing stays pending. A same-day takeover resends the stored text and supersedes nothing, so every failure repeats a notice rather than losing it. Idempotency is unchanged: one D1 claim per UTC day, stored payload, one Idempotency-Key per day (now hull-and-havoc-moderation-digest-*). Docs no longer claim exactly-once delivery. Adds scripts/digest-delivery-test.mjs: one guarded operator test email (no player data, own key prefix, dry run without --confirm-one-live-email), tested against a loopback mock only. Tests: same-run expiry with an empty remaining queue (regression for cleanup-before-digest ordering), cross-day outage carry, abandoned earlier send, same-day takeover, expiredNotAnnounced logging. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…cy review items - docs/digest-activation-runbook.md: ordered, gated steps for mailbox, Resend subdomain DNS (no root MX change), sending-only key, D1 bookmark/export/verify/0005/verify (blocks rehearsed on local D1), sender var and release (coupled to policy approval because main also publishes Pages), one guarded delivery test, secret, ledger-based verification and rollback. - leaderboard-moderation.md: Hull & Havoc subjects, no exactly-once claim, cross-day expiry carry-forward, updated residual gaps. - Policy docs: name finalized, publication record gains review items 7-10 (review commitment, indefinite retention, submit-as-acceptance, operator identity). - Offline privacy screen: provider-retention line aligned with the public page; DRAFT marker unchanged. - tests/branding.test.ts: name shown, package ID unchanged, no earlier title in shipped files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test/build results for release/hull-and-havoc-rc, the rebuilt unsigned artifacts (label Hull & Havoc, package unchanged), the renamed sideload APK in the phone checklist, and a focused Play assessment separating established facts from open interpretation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…licit rules acceptance Policy (public page and offline screens, kept consistent): - Moderation: automatic screening, private reports, human review when attention is needed, no continuous monitoring; reports can expire before review; reports never auto-hide. - Practice: no gameplay upload and no score submission (menu-request caveat kept). - Requests: removal, access, correction, appeal, retention questions, with the identification limits of an accountless game. - Verified-score retention purpose stated; retention unchanged. - Date and the DRAFT marker unchanged. VIEW FULL POLICY on every offline privacy page opens the one canonical URL: window.open + cleared opener in browsers; in the Android app a navigation that Capacitor hands to the system browser (ACTION_VIEW), so no plugin, dependency or permission. The address is always shown after the tap, and a blocked tab is reported. Result page: ACCEPT RULES & SUBMIT (ENTER hint) beside SKIP, a one-line rules summary, LEADERBOARD RULES (opens the rules page) and PRIVACY. The phone keyboard's Done key no longer submits. Client-only, nothing stored, API unchanged. Tests: openExternal unit tests, privacy wording/consistency/canonical URL tests, 12 menu checks (mouse, keyboard, touch, controller, blocked tab) and 7 ranked-ui checks (labels, rules navigation, Done key). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ions Publication record: exact wording changes, link and acceptance behaviour, test results, approval/publication-date procedure (keep the inspector's marker list on approval), and the owner decisions that remain. Review draft and UGC readiness table aligned with explicit acceptance; the draft no longer describes the digest as operating. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…st sender - privacy.ts: the DRAFT PRIVACY POLICY - REVIEW PENDING line becomes the heading PRIVACY POLICY (same line count). The signed-release inspector keeps both draft markers; a new test asserts the approved copy carries none of them. - Policy date stays 2026-11-12 (approval day). If the merge to main happens later, set it to the merge day first. - wrangler.toml: MODERATION_DIGEST_FROM = Hull & Havoc <moderation@notify.davidandrea.ca>. The digest stays disabled until RESEND_API_KEY is installed. - Docs: approval record, sender recorded, runbook step 9.1 done. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.