Repository navigation
feat(docs-flatten): describe every image a doc references, asking before large runs - #1794
Merged
Merged
Conversation
…kets or wiki embeds An image whose name has spaces or accents is usually written percent-encoded, which never matched the file on disk, so it was skipped as not found and kept only its marker. Angle-bracket destinations with spaces and Obsidian embeds were not recognized at all and vanished from the corpus. Paths are now decoded, both forms are parsed, and a link that names only the file resolves to it when the name is unique under the root.
Contributor
Quality GateResult: ✅ all floors passed
Config: .github/quality-gate.yml. Workflow: |
…d BMP and TIFF The 50-image cap described a fraction of a large corpus by default. It is gone: maxImages is an optional cap. When a model calls the tool and more than 20 images still need a description, the run stops before spending and writes nothing, reporting the count and estimated tokens so the model asks the user, then re-runs with confirmImages, maxImages or markers; the user's own chatcli tool call runs directly. BMP and TIFF are converted to PNG, JPEG variants are accepted, a skipped format is reported by extension, and a logo or icon name only skips a small image.
diillson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A user's corpus had 711 images: 521 described, 49 not found, 135 unsupported format, 2 large diagrams skipped as logos/icons, and the default 50-image cap meant the first run described only 50.
Finding images
modelo%20de%20c%C3%A9lulas.png) are decoded; they were not found.and angle-bracket reference definitions are parsed; they vanished from the corpus.![[a.png]],![[img/a.png|alt]],![[a.png|300]]become image markers (notes/PDFs stay as written); a file named without its folder resolves by unique name under the root.Formats and filters
golang.org/x/image, already a dependency);.jfif/.jpe/.pjpeg/.pjpaccepted. A skipped format is reported by extension (unsupported format .heic).No default cap, ask before spending
maxImagesis now an optional cap (default: all).confirmImages=true,maxImages=Norimages=markers. The user's ownchatcli toolcall is marked as direct use and runs.Test plan
chatcli toolmarks direct usego test ./...(plugins, cmd), golangci-lint, patch coverage 88.8%